New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844057 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
(OOO slow)
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 840525



Sign in to add a comment

[TTS] Update Playstore after M-68 for "Tap to Search"

Project Member Reported by donnd@chromium.org, May 17 2018

Issue description

This is a task TODO right after M-68 goes to 100% stable: change the playstore description of Touch to Search to Tap to Search.

The task is to land this google3 CL: https://critique.corp.google.com/#review/195888888

 

Comment 1 by donnd@chromium.org, Jun 11 2018

Status: Fixed (was: Assigned)
Just landed on google3: https://critique.corp.google.com/#review/200100370
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.

Comment 3 by donnd@chromium.org, Jun 11 2018

Labels: -Merge-TBD -M-67 M-68
No merge needed, and updating milestone since change actually affects M-68.

Comment 4 by donnd@chromium.org, Jun 12 2018

Status: Started (was: Fixed)
Needed to revert the CL in #1, will reland eventually.

Comment 5 by donnd@chromium.org, Jun 13 2018

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by donnd@chromium.org, Jun 13 2018

Labels: -Merge-TBD
No merge needed, not a client change.

Comment 8 by donnd@chromium.org, Jun 21 2018

Status: Assigned (was: Fixed)
We need to reland this playstore change when M-68 goes to 100%.  I have the google3 change ready but not sent for review yet (https://critique.corp.google.com/#review/201432576).
Description: Show this description
Summary: [TTS] Update Playstore after M-68 for "Tap to Search" (was: [TTS] Update Playstore after M-67 for "Tap to Search")
I think the time is quickly approaching to push this CL.  Estelle, I'll double-check that it's ready to land.  Let me know when to submit.
The CL on google3 has been sent for review, will submit upon approval -- https://critique.corp.google.com/#review/206177490
Labels: -Pri-3 Pri-1
Estelle, I don't want to jump the gun (again) but I'm thinking that we should enable this Playstore change now, since we're starting to roll out M-68 Stable on Android.  What do you think?
cmasso@, just checking again to see if we need to wait for this playstore update for 100% of stable, and if that has not yet happened.
Status: Fixed (was: Assigned)
Landed on google3: https://critique.corp.google.com/#review/207949486
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
No merge needed.

Sign in to add a comment