New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844050 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

lxc 3.0.0 lxc-info fails

Project Member Reported by haddowk@chromium.org, May 17 2018

Issue description

Due to changes in the config syntax

The command:
sudo lxc-info -P /mnt/moblab/containers -n moblab_base_07 -c lxc.rootfs

returns
lxc.rootfs invalid


The command should be:

sudo lxc-info -P /mnt/moblab/containers -n moblab_base_07 -c lxc.rootfs.path

which returns

lxc.rootfs.path = /mnt/moblab/containers/moblab_base_07/rootfs


 

Comment 1 by jkwang@google.com, May 21 2018

Any update on this? Should move on the lxc upgrade soon.
Sorry I am swamped with some other issues, just getting the unit tests to run seems.  I will bump it to the top of the list.
Do you have instructions on how to run the unit tests ?  I am a little confused about the enviroment required, they seem to be skipped with the regular way to run autotest unittests, https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/utils/unittest_suite.py?rcl=c8b430d021c0de9c29e40d9dd68918c7ee10fdc4&l=110
Sorry #3 was for jkop@ I meant to put it in the CL 
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1064690

Comment 5 by jkop@chromium.org, May 21 2018

Run them like you'd run any other specific unit test suite, e.g.
> autotest/files$ ./utils/unittest_suite.py site_utils.lxc.container_unittest
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8c182fff168e3903bc13a8613a361a0431e80e40

commit 8c182fff168e3903bc13a8613a361a0431e80e40
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Jun 08 23:14:16 2018

[autotest] Change to make lxc-info call work with lxc 3.0.0

There is a change to the config syntax between lxc 2.x.x and
lxc 3.x.x, determine the version of lxc we are running and
make the correct call.

I did it this way rather than just catch the error as I feel
that version differences are going to continue to happen and this
should make it easier to make future changes.

BUG= chromium:844050 
TEST=tested on moblab running lxc.3.x and tryjobs

Change-Id: Ib605a78858c13e464a92dcbbb63668a3b5307f54
Reviewed-on: https://chromium-review.googlesource.com/1064690
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/8c182fff168e3903bc13a8613a361a0431e80e40/site_utils/lxc/container.py
[modify] https://crrev.com/8c182fff168e3903bc13a8613a361a0431e80e40/site_utils/lxc/utils.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6c0402c4ff826b912eb5b7fbb23cf09a455e6c43

commit 6c0402c4ff826b912eb5b7fbb23cf09a455e6c43
Author: Jacob Kopczynski <jkop@chromium.org>
Date: Tue Jun 12 22:53:55 2018

Revert "[autotest] Change to make lxc-info call work with lxc 3.0.0"

This reverts commit 8c182fff168e3903bc13a8613a361a0431e80e40.

Reason for revert: Blocking push to prod.

Original change's description:
> [autotest] Change to make lxc-info call work with lxc 3.0.0
> 
> There is a change to the config syntax between lxc 2.x.x and
> lxc 3.x.x, determine the version of lxc we are running and
> make the correct call.
> 
> I did it this way rather than just catch the error as I feel
> that version differences are going to continue to happen and this
> should make it easier to make future changes.
> 
> BUG= chromium:844050 
> TEST=tested on moblab running lxc.3.x and tryjobs
> 
> Change-Id: Ib605a78858c13e464a92dcbbb63668a3b5307f54
> Reviewed-on: https://chromium-review.googlesource.com/1064690
> Commit-Ready: Keith Haddow <haddowk@chromium.org>
> Tested-by: Keith Haddow <haddowk@chromium.org>
> Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

Bug:  chromium:844050 
Change-Id: Iaf71f27e4bfde2fc705370f7278454e7e1022dbf
Reviewed-on: https://chromium-review.googlesource.com/1098155
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>
Commit-Queue: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/6c0402c4ff826b912eb5b7fbb23cf09a455e6c43/site_utils/lxc/container.py
[modify] https://crrev.com/6c0402c4ff826b912eb5b7fbb23cf09a455e6c43/site_utils/lxc/utils.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/533a06fc012d53d5378f943470a3e3851abd0b08

commit 533a06fc012d53d5378f943470a3e3851abd0b08
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Jun 26 09:55:47 2018

[autotest] Reland: Change to make lxc-info call work with lxc 3.0.0

There is a change to the config syntax between lxc 2.x.x and
lxc 3.x.x, determine the version of lxc we are running and
make the correct call.

I did it this way rather than just catch the error as I feel
that version differences are going to continue to happen and this
should make it easier to make future changes.

Reland fix:
Changed to ensure that the code will not crash in the event of being
called with on a machine where lxc is not installed.

BUG= chromium:844050 
TEST=tested on moblab running lxc.3.x and tryjobs

Change-Id: I9ccb41ae40bbe173d5c03494aee102443ce8533e
Reviewed-on: https://chromium-review.googlesource.com/1110556
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/533a06fc012d53d5378f943470a3e3851abd0b08/site_utils/lxc/container.py
[modify] https://crrev.com/533a06fc012d53d5378f943470a3e3851abd0b08/site_utils/lxc/utils.py

Status: Fixed (was: Assigned)

Sign in to add a comment