New issue
Advanced search Search tips

Issue 844047 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Stop putting : in log file names as Windows barfs on them

Project Member Reported by jayhlee@google.com, May 17 2018

Issue description

Chrome Version: any recent stable release

What steps will reproduce the problem?
(1) run a CroSH command such as "network_diag --hosts".
(2) copy the resultant log file saved by CroSH to a USB drive
(3) plug said drive into a Windows machine.
(4) Windows behaves oddly with the log file because it doesn't like having : in a filename.

Windows reserves colon : character in filenames since it uses the colon to separate drive letter from file path since the early days of DOS:

https://www.quora.com/Why-are-colons-not-allowed-in-the-filenames-of-Windows-files

Log files generally look like:

network_diagnostics_2018-05-17.23:13:41.txt

we should just use something more universally compatible like - in place of the colons.

We often have customers running these diagnostics in guest mode or on a locked down device. They need to copy then email the files via a Windows machine and the colon trips them up.
 

Comment 1 by jayhlee@google.com, May 17 2018

Owner: jayhlee@google.com
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2ad8110030924038f9519235f1b555cfc175c3e7

commit 2ad8110030924038f9519235f1b555cfc175c3e7
Author: Jay Lee <jayhlee@google.com>
Date: Sat May 19 03:08:25 2018

crosh: Don't use colons in log filenames

Windows does not like colons in filenames. Replace colon with dash
to keep Windows systems happy.

BUG= chromium:844047 
TEST=run network_diag command, confirm log filename doesn't contain :

Change-Id: I4125a0d025c46191cfcb82c78a571e08f897fa47
Reviewed-on: https://chromium-review.googlesource.com/1064494
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Jay Lee <jayhlee@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/2ad8110030924038f9519235f1b555cfc175c3e7/crosh/crosh

Comment 3 by jayhlee@google.com, May 19 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment