New issue
Advanced search Search tips

Issue 844043 link

Starred by 3 users
Status: Fixed
Owner:
peconn@chromium.org
Closed: Jun 2018
Cc:
msramek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove cached origin verification with browsing data

Project Member Reported by bauerb@chromium.org, May 17 2018 
The saved origin verification results in OriginVerifier.java should be cleared when the user clears browsing data for the origin in question.

Maybe we should actually save the results with a timestamp and use that timestamp for filtering when clearing browsing data? Or maybe it's better not to store that information in the first place, not sure... Adding Martin for this thoughts.

Comment 1 by peconn@chromium.org, May 17 2018 

Both the Preferences (ChromePreferenceManager.getInstance().getVerifiedDigitalAssetLinks()) and sPackageToCachedOrigins should be cleared.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04471c68a161450b174bcd4b73388a5f3404931e

commit 04471c68a161450b174bcd4b73388a5f3404931e
Author: Peter E Conn <peconn@chromium.org>
Date: Wed Jun 06 12:25:49 2018

🤝 Wipe OriginVerifier persistent data when browsing data cleared.

Bug:  844043 
Change-Id: I8a24df699cf697762cdbcc3ca9259f839c04d212
Reviewed-on: https://chromium-review.googlesource.com/1085053
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564863}
[modify] https://crrev.com/04471c68a161450b174bcd4b73388a5f3404931e/chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java
[modify] https://crrev.com/04471c68a161450b174bcd4b73388a5f3404931e/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
[modify] https://crrev.com/04471c68a161450b174bcd4b73388a5f3404931e/chrome/android/javatests/src/org/chromium/chrome/browser/browserservices/OriginVerifierTest.java
[modify] https://crrev.com/04471c68a161450b174bcd4b73388a5f3404931e/chrome/browser/android/customtabs/origin_verifier.cc
[modify] https://crrev.com/04471c68a161450b174bcd4b73388a5f3404931e/chrome/browser/android/customtabs/origin_verifier.h
[modify] https://crrev.com/04471c68a161450b174bcd4b73388a5f3404931e/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/04471c68a161450b174bcd4b73388a5f3404931e/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc

Comment 3 by peconn@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment