This setting is not being used. Currently all whitelisting is done via sticky content settings, not per-webcontents.
I think we can also remove |should_suppress_notifications| too.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abe26f244693c26aebaa788c829508da2fc1f9e8 commit abe26f244693c26aebaa788c829508da2fc1f9e8 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri May 18 19:36:05 2018 [subresource_filter] Remove whitelist site on reload behavior The behavior isn't used anywhere currently. Bug: 844040 Change-Id: I85af66018842c29c5504e116dc53292323b87a82 Reviewed-on: https://chromium-review.googlesource.com/1064495 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#559992} [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.h [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/chrome/browser/subresource_filter/subresource_filter_browsertest.cc [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/content/browser/subresource_filter_client.h [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/abe26f244693c26aebaa788c829508da2fc1f9e8/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21b71beaa61204e0ff80e215ac3996864dd762cc commit 21b71beaa61204e0ff80e215ac3996864dd762cc Author: Charlie Harrison <csharrison@chromium.org> Date: Fri May 18 21:17:10 2018 [subresource_filter] Remove suppress_notifications option This configuration is not being used currently. Bug: 844040 Change-Id: I975eb7b337738a9cf2988d4000c90fca4b3e5c21 Reviewed-on: https://chromium-review.googlesource.com/1064717 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560038} [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/content/browser/subresource_filter_client.h [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/21b71beaa61204e0ff80e215ac3996864dd762cc/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
There are more cleanups possible now that we've removed these settings, but closing for now.
Comment 1 by csharrison@chromium.org
, May 17 2018