New issue
Advanced search Search tips

Issue 844032 link

Starred by 2 users
Status: Fixed
Owner:
jam@chromium.org
Closed: Jun 2018
Cc:
dougt@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 769401



Sign in to add a comment

Fix ExpectCT with network service

Project Member Reported by jam@chromium.org, May 17 2018 
These two tests fail with network service:
ExpectCTBrowserTest.TestDynamicExpectCTHeaderProcessing
ExpectCTBrowserTest.TestDynamicExpectCTReporting

It looks like they can be fixed by moving the
ChromeExpectCTReporter class to services/network and creating it in NetworkContext instead of ProfileIOData will fix this.

Comment 1 by jam@chromium.org, May 17 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac

Comment 2 by jam@chromium.org, Jun 14 2018

Owner: jam@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffaf5cce6664fcff8acbec356f299a709c85b545

commit ffaf5cce6664fcff8acbec356f299a709c85b545
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jun 18 17:36:58 2018

Move Expect-CT to services/network so that it can work with the network service.

Bug:  844032 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I20c4e95fb05cf87109050f7905fb6a5b468dbf91
Reviewed-on: https://chromium-review.googlesource.com/1102172
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568058}
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/build/android/pylib/gtest/filter/unit_tests_disabled
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/browser/BUILD.gn
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/browser/ssl/chrome_expect_ct_reporter_browsertest.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/browser/ui/webui/net_internals/DEPS
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/common/chrome_features.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/common/chrome_features.h
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/chrome/test/BUILD.gn
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/BUILD.gn
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/OWNERS
[rename] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/expect_ct_reporter.cc
[rename] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/expect_ct_reporter.h
[rename] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/expect_ct_reporter_unittest.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/network_context.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/network_context.h
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/public/cpp/features.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/public/cpp/features.h
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/services/network/url_request_context_builder_mojo.cc
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/ffaf5cce6664fcff8acbec356f299a709c85b545/tools/traffic_annotation/summary/annotations.xml

Comment 4 by jam@chromium.org, Jun 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment