New issue
Advanced search Search tips

Issue 844023 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Flag to test migration UI (--test-encryption-migration-ui) is not working.

Project Member Reported by fukino@chromium.org, May 17 2018

Issue description

Chrome Version: ToT
OS: Chrome

--test-encryption-migration-ui is added to test migration UI on Linux build, but it is not working now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb3d8e91dd4c6f664d7c54f616ccb2ca4a6f9620

commit eb3d8e91dd4c6f664d7c54f616ccb2ca4a6f9620
Author: Naoki Fukino <fukino@chromium.org>
Date: Fri May 18 04:06:10 2018

Show migration UI on Linux when the test flag is enabled.

When the flag for testing the migration UI (--test-encryption-migration-ui)
is enabled, we should show the migration UI regardless of the policy check.
In addition, I added the check for force_dircrypto_if_available() in
FakeCryptohomeClient to make SKIP button working.

Bug:  844023 
Test: On Linux, build and run Chrome for ChromeOS with --test-encryption-migration-ui --login-manager --show-webui-login (needed to work around  issue 844020 ) and check that I can see migration screen and SKIP button works.
Change-Id: I56664a3976e10bd6bad27dcfcb1ce2503a117fc5
Reviewed-on: https://chromium-review.googlesource.com/1064032
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559795}
[modify] https://crrev.com/eb3d8e91dd4c6f664d7c54f616ccb2ca4a6f9620/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/eb3d8e91dd4c6f664d7c54f616ccb2ca4a6f9620/chromeos/dbus/fake_cryptohome_client.cc

Comment 2 by fukino@chromium.org, May 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment