Chrome crashes on login when migration is needed. |
|||||||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) Prepare a profile whose user directory is created with ecryptfs. (2) Upgrade the device which supports ext4 crypto. (3) Try to sign in with the profile created in step 1. What is the expected result? Migration UI is presented. What happens instead? Chrome crashes and sign-in UI falls back to WebUI version
,
May 17 2018
Check out the Gaia dialog impl that shows Gaia screen in a dialog. Maybe we can generalize it to show any WebUI login screen. https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.cc
,
May 18 2018
,
May 18 2018
Hi xiyuan@, jdufault@, Is it possible to ask you to handle this issue? I'm not sure if I can make it for M-68 branch point since I'm not familiar with the overall architecture of the new views-based login and I'm still not sure how this issue should be fixed. (e.g. I guess LoginDisplayHostMojo::GetWizardController() is not implemented intentionally, but I'm still not sure why...) In addition, I have another item which need to land on M68. I'd appreciate it very much if you can take over this issue.
,
May 18 2018
We pushed login to 69 - sorry for not updating the bug. You can reassign the bug to me if you will not have time to take a look - thanks for investigating thus far.
,
May 21 2018
Thank you for updating the target milestone! I'll find a chance to look into this issue after M68 branch point. In the meantime, if you have cycles, please feel free to take this one. Thanks!
,
Jun 13 2018
fukino@, could you help to verify if the migration UI shows up correctly? Think this CL should implement GetWizardController() now: https://chromium-review.googlesource.com/c/chromium/src/+/1087772
,
Jun 13 2018
,
Jun 14 2018
Re:#7 Thank you for taking care of this screen! I tested the migration screen on ToT. The layout seems a bit broken (the footer is misplaced), but I can see the migration screen without Chrome crash.
,
Jun 27 2018
Think the spacing in the bottom is reserved for the shelf, however in views login we moved the shelf into ash, so this additional space is not needed. Can we maybe modify this for views login case? https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/encryption_migration.css?rcl=1ce4571e5093173786966ad4dd2357295094d59f&l=7
,
Jun 27 2018
FYI xiaoyinh@ I believe qnnguyen@ has a CL that eliminates the grey box.
,
Jul 18
fukino@, outside of the grey box is there any remaining work?
,
Jul 19
Hi jdufault@, Except for the gray box, the migration dialog worked properly. On sign-in screen, I still have a remaining task. crbug.com/831099 . I guess this task is to implement UserBoardViewMojo::ShowBannerMessage(). https://codesearch.chromium.org/chromium/src/chrome/browser/chromeos/login/user_board_view_mojo.h?rcl=c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7&l=27 I'll be able to investigate how to implement it tomorrow. (I'm sorry for the delay: I overlooked it) Of course, it'd be great if you have cycles to help the task.
,
Aug 1
Did you have a chance to take a look?
,
Aug 3
I'm working on a CL for issue 831099 . qnnguyen@, are you going to eliminate the gray box? (Re: comment #11) I saw the gray box on ToT two days ago.
,
Aug 9
The grey box has been removed |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fukino@chromium.org
, May 17 2018