BrowserCloseManagerBrowserTest.TestWithOffTheRecordWindowAndRegularDownload has been silently failing |
||||
Issue descriptionThis test has several expectations, of which one is that two BROWSER_CLOSED notifications will be received. The test was passing even though only one such notification was being processed, because the RunLoop used to wait for notifications was being caused to exit prematurely, and the test helper didn't verify the number of received notifications.
,
May 17 2018
-> David
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a78944d35a94696ac1aeb0ee0d94ca7a57cde2d5 commit a78944d35a94696ac1aeb0ee0d94ca7a57cde2d5 Author: Wez <wez@chromium.org> Date: Thu May 17 16:56:29 2018 Add missing expectation to RepeatedNotificationObserver test helper. This test helper is intended to verify that the expected number of notifications are received, but relies on a RunLoop which can be quit too soon by QuitCurrentWhenIdleDeprecated() calls by code-under-test. Bug: 844016 , 844019 Change-Id: I416d24e2accd4ef3834197dd50a445db8fe801d0 Reviewed-on: https://chromium-review.googlesource.com/1064000 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559572} [modify] https://crrev.com/a78944d35a94696ac1aeb0ee0d94ca7a57cde2d5/chrome/browser/lifetime/browser_close_manager_browsertest.cc
,
May 17 2018
,
Aug 23
|
||||
►
Sign in to add a comment |
||||
Comment 1 by w...@chromium.org
, May 17 2018