Issue metadata
Sign in to add a comment
|
Adaptive Toolbar: Fix NTP for BCVC fullscreen |
||||||||||||||||||||||
Issue descriptionWhen the BrowserContainerViewController is fullscreen, there are some layout issues with the NTP, incognito and non-incognito.
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2 commit f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue May 22 06:52:15 2018 Fix NTP for BCVC fullscreen This CL fixes the normal NTP when BCVC is fullscreen, mainly the interactions with the overscroll actions. Bug: 844013 , 836730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If14d459b1261668272e492a3d0c100264811d975 Reviewed-on: https://chromium-review.googlesource.com/1065815 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#560500} [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
,
May 23 2018
,
May 23 2018
The NextAction date has arrived: 2018-05-23
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78de89c79ee15aa6e714895eb509d4f816d93d3a commit 78de89c79ee15aa6e714895eb509d4f816d93d3a Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 23 14:06:29 2018 Fix NTP animation issues This CL fixes an issue with the animation of the NTP when opening a new tab in foreground when BCVC is fullscreen. Bug: 844013 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If2873c5b674058f6132a545feaeb318c466100dc Reviewed-on: https://chromium-review.googlesource.com/1070199 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561062} [modify] https://crrev.com/78de89c79ee15aa6e714895eb509d4f816d93d3a/ios/chrome/browser/ui/browser_view_controller.mm
,
May 23 2018
,
May 29 2018
Verified in 69.0.3444.0 Canary, iPhone X iOS 11.4 beta 6, iPhone 6 iOS 10.3.3, iPhone 7 iOS 11.4 Animation looks good when opening a New Incognito tab when in FS.
,
Jun 21 2018
What user story does this task belong to?
,
Jun 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, May 18 2018