New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 844013 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 2
Type: Task
Q2

Blocking:
issue 836730



Sign in to add a comment

Adaptive Toolbar: Fix NTP for BCVC fullscreen

Project Member Reported by gambard@chromium.org, May 17 2018

Issue description

When the BrowserContainerViewController is fullscreen, there are some layout issues with the NTP, incognito and non-incognito.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d762728bab96990b6850e1edb2cab49c9cf97a0

commit 5d762728bab96990b6850e1edb2cab49c9cf97a0
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri May 18 08:20:07 2018

Fix Open New Incognito Tab animation

This CL fixes the Open New Incognito Tab animation when the
BrowserContainerViewController is in fullscreen.
It is also fixing the animation for the iPhone X.

Bug: 688259,  836730 , 819811,  843931 ,  844013 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I298811b90b42122ff2f805f7888d2d5ff750c2b8
Reviewed-on: https://chromium-review.googlesource.com/1061528
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559837}
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/snapshots/snapshot_generator.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.h
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/features.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/public/features.h
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/web_state/ui/crw_web_controller.mm

Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2

commit f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue May 22 06:52:15 2018

Fix NTP for BCVC fullscreen

This CL fixes the normal NTP when BCVC is fullscreen, mainly the
interactions with the overscroll actions.

Bug:  844013 ,  836730 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If14d459b1261668272e492a3d0c100264811d975
Reviewed-on: https://chromium-review.googlesource.com/1065815
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560500}
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/ntp/new_tab_page_bar.mm
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
[modify] https://crrev.com/f26e9071442a7e7e9a8fb72151aa088c4dbe0bf2/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

Blocking: 836730
NextAction: 2018-05-23
Status: Started (was: Assigned)
The NextAction date has arrived: 2018-05-23
Project Member

Comment 5 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78de89c79ee15aa6e714895eb509d4f816d93d3a

commit 78de89c79ee15aa6e714895eb509d4f816d93d3a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed May 23 14:06:29 2018

Fix NTP animation issues

This CL fixes an issue with the animation of the NTP when opening a new
tab in foreground when BCVC is fullscreen.

Bug:  844013 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If2873c5b674058f6132a545feaeb318c466100dc
Reviewed-on: https://chromium-review.googlesource.com/1070199
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561062}
[modify] https://crrev.com/78de89c79ee15aa6e714895eb509d4f816d93d3a/ios/chrome/browser/ui/browser_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 69.0.3444.0 Canary, iPhone X iOS 11.4 beta 6, iPhone 6 iOS 10.3.3, iPhone 7 iOS 11.4 

Animation looks good when opening a New Incognito tab when in FS.

Comment 8 by cma...@chromium.org, Jun 21 2018

What user story does this task belong to?
Labels: S-Offscreen-Toolbar

Sign in to add a comment