New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 844007 link

Starred by 2 users
Status: Fixed
Owner:
fgor...@chromium.org
Closed: May 2018
Cc:
agrieve@chromium.org
█ nyquist@chromium.org
█ wnwen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Build Output: Fix unused proto warning

Project Member Reported by wnwen@chromium.org, May 17 2018 
[12878/47958] ACTION //third_party/feed:feed_lib_proto_jav...__protoc_java(//build/toolchain/android:android_clang_arm)
src/main/proto/com/google/android/libraries/feed/api/proto/stream_data.proto: warning: Import src/main/proto/search/now/proto/wire/feed/content_id.proto but not used.
src/main/proto/search/now/proto/wire/feed/token.proto: warning: Import src/main/proto/search/now/proto/wire/feed/content_id.proto but not used.

Please fix, remove, or suppress this unused proto warning. A lot of work has gone into making our debug build clean (no extra output), it is up to each of us to keep it that way:  https://crbug.com/805906

Comment 1 by wnwen@chromium.org, May 17 2018 

Hi Filip,

Seems like you added feed_lib_proto_java. Please take a look and see if you can fix/remove or suppress this build warning.

Thanks,

Peter

Comment 2 by fgor...@chromium.org, May 17 2018

Components: UI>Browser>ContentSuggestions>Feed
These are third party protobufs, I'll work with the owners to make a corresponding update.

Comment 3 by twelling...@chromium.org, May 22 2018

Labels: zine-triaged
Status: ExternalDependency (was: Assigned)

Comment 4 by fgor...@chromium.org, May 22 2018 

Opened b/80143435 to track the fix for library.
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/099f0da7f809396e2585d3d27823f091d92c99d2

commit 099f0da7f809396e2585d3d27823f091d92c99d2
Author: Sky Malice <skym@google.com>
Date: Fri May 25 16:53:20 2018

[Feed] Import feed@1a85e92e55d85466faf3c96a45eb02a01c5e2cc9

Monochrome.apk_Dex
        +2 entries fields
       +15 entries methods
        +4 entries types
        +7 entries strings
Monochrome.apk_Breakdown (+16,364 bytes)
      -173 bytes Zip Overhead
      +657 bytes Non-compiled Android resources size
   +12,528 bytes Native code size
      +132 bytes Package metadata size
      +432 bytes Java code size
    +2,788 bytes Compiled Android resources size
Monochrome.apk_Specifics
   +17,492 bytes normalized apk size
        +2 zip entries file count
   +12,528 bytes main lib size
    +1,128 bytes main dex size

Bug:  844007 
Change-Id: Id753ce08cebbee9d56679eee3452f6215d1f9907
Reviewed-on: https://chromium-review.googlesource.com/1073402
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561915}
[modify] https://crrev.com/099f0da7f809396e2585d3d27823f091d92c99d2/DEPS
[modify] https://crrev.com/099f0da7f809396e2585d3d27823f091d92c99d2/third_party/feed/README.chromium
[modify] https://crrev.com/099f0da7f809396e2585d3d27823f091d92c99d2/third_party/feed/java_sources.gni
[modify] https://crrev.com/099f0da7f809396e2585d3d27823f091d92c99d2/third_party/feed/proto_sources.gni

Comment 6 by s...@chromium.org, May 25 2018

Status: Fixed (was: ExternalDependency)
►

Sign in to add a comment