SVG circle with small stroke-dasharray does not render properly
Reported by
rol...@nextendweb.com,
May 17 2018
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36 Example URL: https://jsfiddle.net/oy0xvmyz/ Steps to reproduce the problem: 1. Open: https://jsfiddle.net/oy0xvmyz/ 2. The top svg's red sector looks like a rectangle. The center point is not fine What is the expected behavior? Around the center, it should be sharp and antialised. When you check the second SVG, everything will be fine. What went wrong? https://i.stack.imgur.com/HPEGD.png Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? No Firefox Chrome version: 66.0.3359.170 Channel: n/a OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
May 17 2018
,
May 17 2018
,
May 17 2018
@caryclark a blast from the past (fallout from switching off SK_LEGACY_STROKE_CURVES).
,
May 17 2018
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f6c4d675879dde4e5bf9a8a641a70a7765b3a3e commit 3f6c4d675879dde4e5bf9a8a641a70a7765b3a3e Author: Cary Clark <caryclark@google.com> Date: Tue Dec 04 22:08:36 2018 add define to keep old skia behavior review.skia.org/129243 changes some layout test results in a minor way; add define to keep old skia behavior on the way to rebaselining the tests R=fmalita@chromium.org Bug: 843966 Change-Id: If09ad8e97c02dab56934ec387ab4a4911bd24b29 Reviewed-on: https://chromium-review.googlesource.com/c/1361632 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#613719} [modify] https://crrev.com/3f6c4d675879dde4e5bf9a8a641a70a7765b3a3e/skia/config/SkUserConfig.h
,
Dec 5
The following revision refers to this bug: https://skia.googlesource.com/skia/+/dbf2aec28af9c070993bfbb0330a70407db6dbc4 commit dbf2aec28af9c070993bfbb0330a70407db6dbc4 Author: Cary Clark <caryclark@skia.org> Date: Wed Dec 05 02:16:04 2018 fix circle dash Thin conic dashes are treated as lines both if the curvature is detected as zero, and if the midpoint is close enough to the control point. To fix: Halve the midpoint to control point magic number. Use quad max curvature as a placeholder for conic max curvature. R=reed@google.com,fmalita@chromium.org Bug:843966 Change-Id: Ide43bef8767c03670ffd19fdc38c191d6e2332f3 Reviewed-on: https://skia-review.googlesource.com/c/129243 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Cary Clark <caryclark@skia.org> [modify] https://crrev.com/dbf2aec28af9c070993bfbb0330a70407db6dbc4/src/core/SkStroke.cpp [modify] https://crrev.com/dbf2aec28af9c070993bfbb0330a70407db6dbc4/gm/dashcircle.cpp
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34387a2f85066acb2db15ace2e18cd3035fea5c5 commit 34387a2f85066acb2db15ace2e18cd3035fea5c5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Dec 05 04:14:44 2018 Roll src/third_party/skia 7d1eb33aec65..dbf2aec28af9 (1 commits) https://skia.googlesource.com/skia.git/+log/7d1eb33aec65..dbf2aec28af9 git log 7d1eb33aec65..dbf2aec28af9 --date=short --no-merges --format='%ad %ae %s' 2018-12-05 caryclark@skia.org fix circle dash Created with: gclient setdep -r src/third_party/skia@dbf2aec28af9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:843966 TBR=jcgregorio@chromium.org Change-Id: Iff9f1cfad1d321d305b294b7a250b6c33cb22579 Reviewed-on: https://chromium-review.googlesource.com/c/1362557 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613863} [modify] https://crrev.com/34387a2f85066acb2db15ace2e18cd3035fea5c5/DEPS
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6 commit 59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6 Author: Cary Clark <caryclark@google.com> Date: Thu Dec 06 21:40:08 2018 remove skia legacy define Skia change has landed. Looks like a handful of tests have minor changes. R=fmalita@chromium.org Bug: 843966 Change-Id: I5809a7a317e33a20c738a1b3ce4156a886b4d174 Reviewed-on: https://chromium-review.googlesource.com/c/1363213 Commit-Queue: Cary Clark <caryclark@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#614500} [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/skia/config/SkUserConfig.h [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.png [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/text-text-08-b-expected.png [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/linux/svg/text/text-selection-deco-01-b-expected.png [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-08-b-expected.png [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/stroking-expected.png [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/stroking-expected.png [modify] https://crrev.com/59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6/third_party/blink/web_tests/platform/mac/fast/text/stroking-expected.png
,
Dec 11
The following revision refers to this bug: https://skia.googlesource.com/skia/+/a10494c302e68dd7d4f34ce4b41cb9b05d78604c commit a10494c302e68dd7d4f34ce4b41cb9b05d78604c Author: Cary Clark <caryclark@skia.org> Date: Tue Dec 11 01:01:21 2018 remove legacy switch Chrome tests have been rebased and legacy define has been removed, so remove from Skia as well. R=fmalita@chromium.org Bug:843966 Change-Id: I3794b8457c581f71d4bd30eb81d6fa4c8a589cad Reviewed-on: https://skia-review.googlesource.com/c/176224 Auto-Submit: Cary Clark <caryclark@skia.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> [modify] https://crrev.com/a10494c302e68dd7d4f34ce4b41cb9b05d78604c/src/core/SkStroke.cpp
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52a1ac72f5cce11433ed9f4324b7de1253de1cc5 commit 52a1ac72f5cce11433ed9f4324b7de1253de1cc5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:56:57 2018 Roll src/third_party/skia 15640698497a..a10494c302e6 (1 commits) https://skia.googlesource.com/skia.git/+log/15640698497a..a10494c302e6 git log 15640698497a..a10494c302e6 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 caryclark@skia.org remove legacy switch Created with: gclient setdep -r src/third_party/skia@a10494c302e6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:843966 TBR=ethannicholas@chromium.org Change-Id: I317bbc0e19278427b380be8160c6e46d1f9c302c Reviewed-on: https://chromium-review.googlesource.com/c/1370650 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615405} [modify] https://crrev.com/52a1ac72f5cce11433ed9f4324b7de1253de1cc5/DEPS
,
Dec 11
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by woxxom@gmail.com
, May 17 2018