New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843963 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Font size of 'IP address','Routing prefix' & 'Gateway' details increases after disabling 'Configure IP address automatically' option in chrome://settings

Project Member Reported by mmanchala@chromium.org, May 17 2018

Issue description

Chrome Version:  68.0.3431.0/10682.0.0 dev-channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings page
(2)Now at 'Network' section click on Wi-Fi -> select Connected Wi-Fi network -> In connected Wi-Fi details page click on 'Network' so that 'IP address','Routing prefix','Gateway' & 'IPv6 address' details are seen at 'Configure IP address automatically'
(3)Disable 'Configure IP address automatically' option and observe increase in font size of 'IP address','Routing prefix' & 'Gateway' details
(Please refer video and screenshot)

Expected: Increase in font size should not be seen for 'IP address','Routing prefix' & 'Gateway' details
Actual: Instead increase in font size is seen for 'IP address','Routing prefix' & 'Gateway' details
 
This is Regression issue as same is working fine in 68.0.3425.0/10666.0.0  dev-channel Reks

@stevenjb: Please confirm the Issue
 
Actual_Font.webm
574 KB View Download
Actual_Font.jpg
105 KB View Download
Expected_Font.jpg
86.4 KB View Download
Expected_Font.webm
435 KB View Download
Status: Assigned (was: Untriaged)
Cc: dpa...@chromium.org
Labels: -Pri-1 Pri-2
I can't repro this on a dev channel on eve. There may be board specific font issues, or it may be a new regression in the Settings fonts, I'll test on ToT.

I can repro this on a linux chromeos build, so I suspect this is a recent regression related to font sizes in Settings. I'll try to identify the change since it could be causing other issues (although this is an unusual case where we transition between read-only and modifiable fields).

Cc: hcarmona@chromium.org
Status: Started (was: Assigned)
+hcarmona@

This was introduced here:
https://chromium-review.googlesource.com/1015644

Fix is up:
https://chromium-review.googlesource.com/c/chromium/src/+/1065200

Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e490e35227a6ea1ef5583549418be13619234abd

commit e490e35227a6ea1ef5583549418be13619234abd
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri May 18 21:17:33 2018

Fix styling for network config for Polymer 2.1.3

Regression was introduced in:
https://chromium-review.googlesource.com/c/chromium/src/+/1015644

Bug:  843963 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I51a2496caf6b41650216963593f38c85dcb39d7f
Reviewed-on: https://chromium-review.googlesource.com/1065200
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560039}
[modify] https://crrev.com/e490e35227a6ea1ef5583549418be13619234abd/ui/webui/resources/cr_components/chromeos/network/network_property_list.html
[modify] https://crrev.com/e490e35227a6ea1ef5583549418be13619234abd/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html

Status: Fixed (was: Started)
Cc: steve...@chromium.org
 Issue 845126  has been merged into this issue.

Sign in to add a comment