New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843961 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task


Participants' hotlists:
Audio-Service


Sign in to add a comment

Parameterize browser tests to run with audio service in and out of process

Project Member Reported by guidou@chromium.org, May 17 2018

Issue description

This allows us to have coverage in the chromium waterfall.
 

Comment 1 by guidou@chromium.org, May 17 2018

Cc: maxmorin@chromium.org olka@chromium.org

Comment 2 by olka@chromium.org, May 17 2018

Cc: gab@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7c7b3050468f827b4ae64b974ab48532a0e7915

commit f7c7b3050468f827b4ae64b974ab48532a0e7915
Author: Max Morin <maxmorin@chromium.org>
Date: Thu May 17 12:17:33 2018

Parametrize WebRtcAudioBrowserTest.

This allows us to test both "out of process audio service" and the
current code on the waterfall.

Bug:  843961 
Change-Id: I2b20ffb821c6f1dc01ddbc45365f82e12a87a987
Reviewed-on: https://chromium-review.googlesource.com/1063753
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559497}
[modify] https://crrev.com/f7c7b3050468f827b4ae64b974ab48532a0e7915/content/browser/webrtc/webrtc_audio_browsertest.cc
[modify] https://crrev.com/f7c7b3050468f827b4ae64b974ab48532a0e7915/services/audio/owning_audio_manager_accessor.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3bae02534c87ed0e06b1b915cea5992ac9c8491

commit b3bae02534c87ed0e06b1b915cea5992ac9c8491
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu May 17 13:45:14 2018

Parameterize WebRtcGetMediaDevicesBrowserTest

This allows running with the audio service running in and out of
process.

Bug:  843961 
Change-Id: Id756240c3e3dd3d45d4477f5ff85a35b7d13356c
Reviewed-on: https://chromium-review.googlesource.com/1064057
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559510}
[modify] https://crrev.com/b3bae02534c87ed0e06b1b915cea5992ac9c8491/chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fd42c9bf01c6ce020618cd2be0282a7646fb218

commit 8fd42c9bf01c6ce020618cd2be0282a7646fb218
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu May 17 13:48:54 2018

Parameterize WebRtcGetUserMediaBrowserTest

This allows running with the audio service in and out of process.

Bug:  843961 
Change-Id: I205c1b78997f5cdf40705b8100d90fb08e176fd5
Reviewed-on: https://chromium-review.googlesource.com/1064063
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559512}
[modify] https://crrev.com/8fd42c9bf01c6ce020618cd2be0282a7646fb218/content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64acb3d4a320b5fc9850de3338237a482cd5906c

commit 64acb3d4a320b5fc9850de3338237a482cd5906c
Author: Max Morin <maxmorin@chromium.org>
Date: Mon May 21 21:58:27 2018

Parametrize CastStreamingApiTestWithPixelOutput

This gives us waterfall coverage for loopback audio streams.

Bug:  843961 
Change-Id: I350382ed055f894e5a44edcf7e5ec4b851835aab
Reviewed-on: https://chromium-review.googlesource.com/1065992
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560365}
[modify] https://crrev.com/64acb3d4a320b5fc9850de3338237a482cd5906c/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

Status: Fixed (was: Assigned)
We should have decent test coverage now.
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment