New issue
Advanced search Search tips

Issue 843960 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Security
Team-Accessibility



Sign in to add a comment

Heap-use-after-free in content::RenderFrameImpl::PostAccessibilityEvent

Project Member Reported by ClusterFuzz, May 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6374202576470016

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x61d000025248
Crash State:
  content::RenderFrameImpl::PostAccessibilityEvent
  blink::AXObjectCacheImpl::PostPlatformNotification
  blink::AXObjectCacheImpl::NotificationPostTimerFired
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=527199:527221

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6374202576470016

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 17 2018

Labels: OS-Windows OS-Mac
Project Member

Comment 2 by ClusterFuzz, May 17 2018

Components: Blink>Accessibility Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by sheriffbot@chromium.org, May 17 2018

Labels: M-68
Project Member

Comment 4 by sheriffbot@chromium.org, May 17 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, May 17 2018

Labels: Pri-1
Cc: pdr@chromium.org dmazz...@chromium.org
Owner: aleventhal@chromium.org
Status: Assigned (was: Untriaged)
Could be related to your recent changes.

0b61507	by	aleventhal@chromium.org	
on 2018-05-17 14:25 (local)
ARIA tables using table CSS incompletely have bad AX structure
3f72dc8	by	aleventhal@chromium.org	
on 2018-05-16 15:28 (local)
Any ARIA attribute should cause a node to be exposed
a3f82b7	by	aleventhal@chromium.org	
on 2018-05-16 12:13 (local)
Aria details should force spans to be exposed

Comment 7 by aarya@google.com, May 28 2018

 Issue 825769  has been merged into this issue.
Project Member

Comment 8 by sheriffbot@chromium.org, May 30 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 9 by sheriffbot@chromium.org, May 31 2018

aleventhal: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: aboxhall@chromium.org
Friendly ping. :) We need to get fixes for High severity vulnerabilities shipped to users in 60 days (see https://chromium.googlesource.com/chromium/src/+/master/docs/security/severity-guidelines.md#High-severity).

Also, does this code run on Android, Chrome OS, and/or Fuchsia? Please check the boxes if so. Thanks!
Project Member

Comment 11 by sheriffbot@chromium.org, Jun 20 2018

aleventhal: Uh oh! This issue still open and hasn't been updated in the last 34 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: aleventhal@chromium.org
Owner: dmazz...@chromium.org
Hey Dominic, hate to do this to you, but this seems accessibility-related and aleventhal hasn't been responsive, so do you think you could find an appropriate owner for this one?  Thanks heaps! 
I've got it, apologies for overlooking it.
Owner: aleventhal@chromium.org

Comment 15 Deleted

Comment 16 Deleted

I have created a layout test from this that crashes as far back as November 29, 2017. I'm having trouble finding a version where it doesn't crash, because if I go back far enough, the layout tests complain about dependencies and don't run. If someone experienced wants to help with that, it might be helpful.

Either this never worked or regressed a long time before the CL's in comment 6 were landed. Those don't make sense for regressing this anyway, as there are no tables or ARIA in the testcase.

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b51b89bac38a15c9e48eba313673b0b32f471f

commit e0b51b89bac38a15c9e48eba313673b0b32f471f
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Tue Jul 03 03:18:03 2018

Guard against |this| being deleted in test script

The layout bugs test runner uses an altered code path to post a11y
notifications, that allows a listener to delete the very object
that is firing the notifications. Do not attempt to further process a11y
notifications for objects that are detached.

Bug:  843960 
Change-Id: I1e10ee014855c1d8f6fbf06c29c5a51c19fe1330
Reviewed-on: https://chromium-review.googlesource.com/1122714
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572097}
[modify] https://crrev.com/e0b51b89bac38a15c9e48eba313673b0b32f471f/content/shell/test_runner/web_frame_test_proxy.h

Project Member

Comment 19 by ClusterFuzz, Jul 3

ClusterFuzz has detected this issue as fixed in range 572096:572097.

Detailed report: https://clusterfuzz.com/testcase?key=6374202576470016

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x61d000025248
Crash State:
  content::RenderFrameImpl::PostAccessibilityEvent
  blink::AXObjectCacheImpl::PostPlatformNotification
  blink::AXObjectCacheImpl::NotificationPostTimerFired
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=572096:572097

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6374202576470016

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 20 by ClusterFuzz, Jul 3

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6374202576470016 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 21 by sheriffbot@chromium.org, Jul 3

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
This does not need any additional merges, as it affects tests only. The bug was in the test runner.
Labels: -ReleaseBlock-Stable
Project Member

Comment 24 by sheriffbot@chromium.org, Aug 3

Labels: Merge-Request-69
Project Member

Comment 25 by sheriffbot@chromium.org, Aug 3

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ (Security TPM) for merge review.
Labels: -M-68 -Merge-Review-69 M-69 Merge-Rejected-69
No merge needed.
Project Member

Comment 28 by sheriffbot@chromium.org, Oct 9

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment