Regression: Cursor does not stay in the textbox after entering invalid input for pages on Print overlay
Reported by
vineetha...@etouch.net,
May 17 2018
|
||||
Issue descriptionChrome Version: 68.0.3432.3 (Official Build) Revision 5aacd4d4350de37f394edd3095576d2bc7daf56c-refs/branch-heads/3432@{#6}(32/64 bit) OS: Mac(10.12.6,10.13.1), 10.13.5(Macbook Pro Touchbar), Windows(7,8,8.1,10) and Linux(14.04) OS Pre-condition: Enabled 'Enable new Print Preview UI' flag from chrome://flags What steps will reproduce the problem? (1) Launch Chrome open NTP and give print command using 'Ctrl+P'to open Print Preview overlay. (2) In Pages Section , choose the second option button and provide an invalid input(e.g: 678 or hhh) and observe. Actual Result: Cursor does not stay in the textbox after entering invalid input for pages. Expected Result: Cursor should remain in the textbox after entering invalid input for pages. This is regression issue broken in ‘M-67’ and providing the bisect using per-revision bisect, Good build: 67.0.3382.0(Revision: 546347) Bad build : 67.0.3383.0(Revision: 546671) You are probably looking for a change made after 546503 (known good), but no later than 546504 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b946afdea90587afd06d59fda9ba9b3d4c132568..eee63eee9be83197a081b054cc5e07d0a593e58d Suspect: https://chromium.googlesource.com/chromium/src/+/eee63eee9be83197a081b054cc5e07d0a593e58d @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
May 22 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7cf8ab129b7590cccd12ca0d243a93573311d37 commit a7cf8ab129b7590cccd12ca0d243a93573311d37 Author: rbpotter <rbpotter@chromium.org> Date: Wed May 23 01:41:54 2018 Print Preview Componentization: Fix focus issue Ensure focus remains in the textfield after the user enters a new value, even if this changes the validity of the input. Bug: 843952 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0fec55a89c10d4b4dcbaff219927ca26fd650594 Reviewed-on: https://chromium-review.googlesource.com/1069254 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#560880} [modify] https://crrev.com/a7cf8ab129b7590cccd12ca0d243a93573311d37/chrome/browser/resources/print_preview/new/settings_behavior.js
,
May 23 2018
Update : Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.5), Windows(7,8,8.1,10) and Linux(14.04) OS with latest Canary Chrome version #68.0.3438.0 and the issue is fixed. Kindly refer the attached screen cast.
,
May 25 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thestig@chromium.org
, May 17 2018