New issue
Advanced search Search tips

Issue 843951 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Dev Tools sources file tree drag action animates over whole screen widthq

Reported by zachary....@westwing.pl, May 17 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3423.2 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools on any website 
2. Go to "Sources" Tab
3. Try dragging a single file from the file tree
4. You should see the file being dragged span across all monitors in width

What is the expected behavior?
The dragged file should be a small contained rectangle

What went wrong?
It shows up as a bar on all connected screens. Full-width

Did this work before? N/A 

Chrome version: 68.0.3423.2  Channel: dev
OS Version: OS X 10.13.4
Flash Version:
 
Screenshot.png
85.0 KB View Download
Labels: Needs-Triage-M68

Comment 2 by caseq@chromium.org, May 17 2018

Components: -Platform>DevTools Platform>DevTools>Authoring
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8591c53a16ed870806c419df59046be8da4d3ae

commit e8591c53a16ed870806c419df59046be8da4d3ae
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed May 30 00:11:27 2018

DevTools: Lazily compute the TreeOutline selection margin on mousedown

Bug:  843951 
Change-Id: I4e71d3745ce214f467e86a338aa03ef630a2f1b0
Reviewed-on: https://chromium-review.googlesource.com/1068201
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562666}
[modify] https://crrev.com/e8591c53a16ed870806c419df59046be8da4d3ae/third_party/blink/renderer/devtools/front_end/ui/treeoutline.js

Status: Fixed (was: Assigned)
Labels: TE-Verified-69.0.3445.0 TE-Verified-M69
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #68.0.3423.2.

Verified the fix on Mac 10.13.3 using Chrome version #69.0.3445.0 as per the comment #0.
Attaching screen cast for reference.
Observed that dragged file is a small contained rectangle.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
843951.mp4
558 KB View Download

Sign in to add a comment