Issue metadata
Sign in to add a comment
|
11.6%-19.3% regression in system_health.common_desktop at 558310:558654 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 17 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17b15048240000
,
May 17 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/17b15048240000 Apply fixed-position scroll offset if the containing block is ancestor. by chrishtr@chromium.org https://chromium.googlesource.com/chromium/src/+/edc066c316b24fb3dea226ae6c1c5c1fdee062c3 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 18 2018
The first graph on the "all pages regressed" page points at this range: https://chromium.googlesource.com/chromium/src/+log/b8a0255907b5bea51f10c0caecaced971b0045e1%5E..1893a97da066e0f8408172aa3977d6b27b3087d1?pretty=fuller&n=1000 which includes this patch: https://chromium.googlesource.com/chromium/src/+/e931d2aecb4d72946962e57e7e1586668071b504 which introduced the bug which my patch fixed. Same goes for other graphs. Therefore my patch is just bringing things back to normal. +cc pdr to add any commentary, but a similar set of graphs moved in the opposite direction when he landed his first patch.
,
May 18 2018
"points at" -> means goes from the value after my patch to the value before my patch.
,
May 21 2018
Yes, these graphs are just returning to baseline after my incorrect patch. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 17 2018