New issue
Advanced search Search tips

Issue 843949 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.6%-19.3% regression in system_health.common_desktop at 558310:558654

Project Member Reported by sullivan@chromium.org, May 17 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 17 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=843949

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=75f6ecc61da362033a7f36a0c1d8a1fe95665a7d7831572e244c8b5f214a96dd


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-air
chromium-rel-mac12
chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 17 2018

Cc: chrishtr@chromium.org
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/17b15048240000

Apply fixed-position scroll offset if the containing block is ancestor. by chrishtr@chromium.org
https://chromium.googlesource.com/chromium/src/+/edc066c316b24fb3dea226ae6c1c5c1fdee062c3

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -chrishtr@chromium.org pdr@chromium.org
Status: WontFix (was: Assigned)
The first graph on the "all pages regressed" page points at this range:

https://chromium.googlesource.com/chromium/src/+log/b8a0255907b5bea51f10c0caecaced971b0045e1%5E..1893a97da066e0f8408172aa3977d6b27b3087d1?pretty=fuller&n=1000

which includes this patch:

https://chromium.googlesource.com/chromium/src/+/e931d2aecb4d72946962e57e7e1586668071b504

which introduced the bug which my patch fixed. Same goes for other graphs.

Therefore my patch is just bringing things back to normal.

+cc pdr to add any commentary, but a similar set of graphs moved in the opposite
direction when he landed his first patch.
"points at" -> means goes from the value after my patch to the value before my
patch.

Comment 6 by pdr@chromium.org, May 21 2018

Yes, these graphs are just returning to baseline after my incorrect patch.

Sign in to add a comment