New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843945 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome
Pri: 2
Type: Bug

Blocked on:
issue 879604



Sign in to add a comment

13 failing tests in LayoutTests/external/wpt/cookies/ involving random numbers

Project Member Reported by foolip@chromium.org, May 17 2018

Issue description

With https://chromium-review.googlesource.com/c/chromium/src/+/1061458 upstream tools changes will change the results of tests in LayoutTests/external/wpt/cookies/, from failing very hard to failing in more interesting ways.

13 of the tests have random numbers in their error messages, and will therefore have to be disabled in TestExpectations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36670a32fb24c76cbba10511911f17339204d2c9

commit 36670a32fb24c76cbba10511911f17339204d2c9
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Thu May 17 12:42:08 2018

Roll in new version of WPT tools

https://github.com/w3c/web-platform-tests/pull/10985 changed lint.py
and wpt-importer is now failing because of it:
https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17652

chromium.patch did not apply cleanly, so the changes had to be rebased
on the new wpt version.	This was much easier within the	wpt repo
itself, so the patch is	changed	to apply within	the repo.

Bug:  843799 , 843945
Change-Id: I1ed9895b2461243c38fea552706960a3b99db2b6
Reviewed-on: https://chromium-review.googlesource.com/1061458
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559502}
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.document-cookie.non-secure-expected.txt
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.http.non-secure-expected.txt
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.document-cookie.non-secure-expected.txt
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.http.non-secure-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.http.secure-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/document-cookie.non-secure-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/fetch-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-get-blank-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-get-blank-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-post-blank-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-post-blank-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/iframe-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/iframe-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/img-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/window-open-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/window-open-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/secure/cookie-forcing-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/secure/create-cookie-http-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/README.chromium
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/WPTWhiteList
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/checkout.sh
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/chromium.patch
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/CONTRIBUTING.md
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/blink/tools/blinkpy/third_party/wpt/wpt/config.default.json
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/lint/lint.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/item.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/sourcefile.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/browser.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/run.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/testfiles.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/config.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/server.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/__init__.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/base.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/openssl.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/pregenerated.py

Comment 2 by mmenke@chromium.org, May 23 2018

Labels: Network-Triaged

Comment 3 by mmenke@chromium.org, May 23 2018

Cc: mkwst@chromium.org

Comment 4 by mkwst@chromium.org, May 24 2018

Labels: -Pri-3 OS-Android OS-Chrome OS-Linux OS-Windows Pri-2
Owner: fhorschig@chromium.org
Status: Assigned (was: Untriaged)
fhorschig@: Since you're poking at other cookies tests, would you be interested in poking at these as well? It looks like the following tests are the ones which are causing issues:

crbug.com/843945 external/wpt/cookies/prefix/__secure.http.secure.html [ Failure ]
crbug.com/843945 external/wpt/cookies/prefix/document-cookie.non-secure.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/fetch.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/form-get-blank-reload.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/form-get-blank.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/form-post-blank-reload.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/form-post-blank.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/iframe-reload.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/iframe.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/img.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/window-open-reload.html [ Failure ]
crbug.com/843945 external/wpt/cookies/samesite/window-open.html [ Failure ]
crbug.com/843945 external/wpt/cookies/secure/create-cookie-http.html [ Failure ]

Thanks!
Yes, I can have a look.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd

commit caa764f5fe713b39ee59ce279dbeb22c9b88a0bd
Author: Mike West <mkwst@chromium.org>
Date: Fri Aug 17 10:45:29 2018

Fix cookie prefix tests.

The layout tests aren't testing much at the moment, as they're never
served over HTTPS. This patch creates `.https` versions of the tests
and reworks them to actually exercise the behavior of `__Host` and
`__Secure` cookie prefixes.

Bug: 843945
Change-Id: I31968133ca8846f3ffc4faec2339e3d0d03c77f8
Reviewed-on: https://chromium-review.googlesource.com/1179150
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584016}
[modify] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.document-cookie.html
[add] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.document-cookie.https.html
[add] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.header.html
[add] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.header.https.html
[delete] https://crrev.com/46b0d6a919ebd3cb078969265a8831906bdd0ade/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.http.non-secure.html
[rename] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.document-cookie.html
[copy] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.document-cookie.https.html
[rename] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.header.html
[rename] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.header.https.html
[delete] https://crrev.com/46b0d6a919ebd3cb078969265a8831906bdd0ade/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.http.secure-expected.txt
[delete] https://crrev.com/46b0d6a919ebd3cb078969265a8831906bdd0ade/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/document-cookie.non-secure-expected.txt
[modify] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/document-cookie.non-secure.html
[modify] https://crrev.com/caa764f5fe713b39ee59ce279dbeb22c9b88a0bd/third_party/WebKit/LayoutTests/external/wpt/cookies/resources/cookie-helper.sub.js
[delete] https://crrev.com/46b0d6a919ebd3cb078969265a8831906bdd0ade/third_party/WebKit/LayoutTests/external/wpt/cookies/secure/cookie-forcing-expected.txt
[delete] https://crrev.com/46b0d6a919ebd3cb078969265a8831906bdd0ade/third_party/WebKit/LayoutTests/external/wpt/cookies/secure/cookie-forcing.html

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3865efad3acd75d3cdb3b9d8da3687604321db0

commit f3865efad3acd75d3cdb3b9d8da3687604321db0
Author: Mike West <mkwst@chromium.org>
Date: Fri Aug 31 06:13:18 2018

'content_shell' should allow third-party cookies in layout test mode.

Several cookie tests are failing under content shell because it defaults
to blocking third-party cookies. We should invert that default in order
to correctly run web platform tests.

Bug: 843945
Change-Id: Ifead36d9b890ea603ea14538caff56ad579cb83e
Reviewed-on: https://chromium-review.googlesource.com/1196547
Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587953}
[modify] https://crrev.com/f3865efad3acd75d3cdb3b9d8da3687604321db0/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/f3865efad3acd75d3cdb3b9d8da3687604321db0/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/fetch-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-get-blank-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-get-blank-reload-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-post-blank-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-post-blank-reload-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/iframe-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/iframe-reload-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/img-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/window-open-expected.txt
[delete] https://crrev.com/c275cc7d548bee49638251e138b15ff3ddcea175/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/window-open-reload-expected.txt

Blockedon: 879604

Sign in to add a comment