Issue metadata
Sign in to add a comment
|
M67: network request annotations changes broke proxy setup |
||||||||||||||||||||||
Issue description//tools/bisect-builds.py tells me https://chromium-review.googlesource.com/c/chromium/src/+/934126 is the likely culprit, hence the bug title. Ever since M67 was promoted to beta and I started using it, I've been having some problems with some of my corporate SSO URLs -- one of the most annoying bits is that I've been unable to log into Gerrit with my Intel account in M67, as the Google account login form redirects me to my SSO page, which fails to load with a 'connection closed' error. What changed is that Chrome is now reading my proxy environment variables instead of getting it from my desktop environment. I'm on Linux (Fedora 27) running Plasma 5. With M66, chrome://net-internals/#proxy says Effective proxy settings PAC script: http://wpad/wpad.dat Source: KDE Original proxy settings Auto-detect Source: KDE whereas M67 has Effective proxy settings Proxy server for FTP: <my $ftp_proxy value> Proxy server for HTTP: <my $http_proxy value> Proxy server for HTTPS: <my $https_proxy value> Bypass list: <my $no_proxy value> Arguably things should still work with the proxy settings found in my environment variables, but in any case this change in the source of the proxy settings is certainly confusing and possibly unwanted.
,
May 18 2018
I don't think that it would be related to annotations. The annotation changes either result in a crash (if there is a bug), or don't modify any behavior. I think a member of net team can investigate this issue better, so removing the Assigned status, but I increase the priority.
,
May 18 2018
Thank you. FWIW, I've just built master and the behavior is still broken there.
,
May 18 2018
Thanks for the report! Your analysis in comment #0 appears to be spot on. There was a regression from https://chromium-review.googlesource.com/c/chromium/src/+/934126 in how proxy settings are obtained on Linux. The fix should be simple enough to backport to M67.
,
May 18 2018
@raphael.kubo.da: If you get the chance, can you try patching my change in to confirm fix? In your checkout run: git cl patch https://chromium-review.googlesource.com/#/c/chromium/src/+/1066562 Then re-build.
,
May 18 2018
,
May 18 2018
,
May 18 2018
M67 Stable promotion is coming VERY soon. Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
May 18 2018
Thanks, I can confirm the CL above fixes the issues here.
For the record, net-internals/#proxy shows a message that's slightly different from what I had in M66:
Effective proxy settings
PAC script: http://wpad/wpad.dat
Original proxy settings
Auto-detect
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd032fb6004648637d75ac7e3c8677c7e2612811 commit cd032fb6004648637d75ac7e3c8677c7e2612811 Author: Eric Roman <eroman@chromium.org> Date: Fri May 18 21:40:13 2018 Fix Linux proxy settings retrieval. Only the environment variables were being consulted and not the desktop environment's settings. Bug: 843942 Change-Id: I22c850717565b219f8ac0dc7566085cccc81af08 Reviewed-on: https://chromium-review.googlesource.com/1066562 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560054} [modify] https://crrev.com/cd032fb6004648637d75ac7e3c8677c7e2612811/net/proxy_resolution/proxy_config_service_linux.cc [modify] https://crrev.com/cd032fb6004648637d75ac7e3c8677c7e2612811/net/proxy_resolution/proxy_config_service_linux.h
,
May 18 2018
Pls update the bug with canary result on Monday morning and request a merge to M67 if change looks good in canary and safe to merge. Thank you.
,
May 21 2018
The NextAction date has arrived: 2018-05-21
,
May 21 2018
Looks good on Canary.
,
May 21 2018
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 21 2018
Approving merge to M67 branch 3396 based on #4, #9 and #14. Please merge ASAP and mark bug as fixed after the merge. Thank you.
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d800f97e4655720ee2efe8a2e4385077dd681c2 commit 5d800f97e4655720ee2efe8a2e4385077dd681c2 Author: Eric Roman <eroman@chromium.org> Date: Mon May 21 20:36:27 2018 Fix Linux proxy settings retrieval. Only the environment variables were being consulted and not the desktop environment's settings. TBR=eroman@chromium.org (cherry picked from commit cd032fb6004648637d75ac7e3c8677c7e2612811) Bug: 843942 Change-Id: I22c850717565b219f8ac0dc7566085cccc81af08 Reviewed-on: https://chromium-review.googlesource.com/1066562 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#560054} Reviewed-on: https://chromium-review.googlesource.com/1067789 Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#667} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/5d800f97e4655720ee2efe8a2e4385077dd681c2/net/proxy_resolution/proxy_config_service_linux.cc [modify] https://crrev.com/5d800f97e4655720ee2efe8a2e4385077dd681c2/net/proxy_resolution/proxy_config_service_linux.h
,
May 21 2018
,
May 21 2018
@raphael.kubo.da.costa: Thanks for testing! The small difference you noticed in output is expected (the system source of proxy settings are no longer tracked). The fix will be in the next beta update. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msramek@chromium.org
, May 17 2018