Issue metadata
Sign in to add a comment
|
Popup Menu: Disabled items are not in disabled color |
||||||||||||||||||||||
Issue descriptionWith UI refresh flag enabled What steps will reproduce the problem? (1) Open a NTP (2) Open the tools menu What is the expected result? The actions items (Find in Page, Request Desktop Site...) should be disabled. What happens instead? There are in blue color. However, tapping on them does nothing
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9214f5af9529d1689093ac29705bf4bb1d57acac commit 9214f5af9529d1689093ac29705bf4bb1d57acac Author: Gauthier Ambard <gambard@chromium.org> Date: Thu May 17 12:57:29 2018 Fix the color of tools menu's disabled elements The tools menu disabled elements had the standard blue color. This CL makes sure that they have the correct grey color. Bug: 843939 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iddbd9e8ea33d329cd5552d77d3acd54db9b5473a Reviewed-on: https://chromium-review.googlesource.com/1064050 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#559505} [modify] https://crrev.com/9214f5af9529d1689093ac29705bf4bb1d57acac/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
,
May 17 2018
,
May 22 2018
Verified in: App Version: 68.0.3437.0 canary Devices: iPhone 6S Plus, iPhone 8, iPad Mini iOS Versions: 10.3.3, 11.2.6, 11.4 beta 6 Action items like FIP, Read Later, Bookmark, Request Desktop Site.. are disabled in NTP and also, displayed in grey color.
,
May 23 2018
The NextAction date has arrived: 2018-05-23 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gambard@chromium.org
, May 17 2018