All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill and DeletingFrameUnderSuggestion are flaky on ChromeOS |
||||||||||
Issue descriptionSample logs: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5703 https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5701 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/8133 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/8155 ../../chrome/browser/autofill/autofill_interactive_uitest.cc:180: Failure Value of: loop_runner_->loop_running() Actual: false Expected: true Stack trace: #0 0x0000007730ec testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000000772ac9 testing::internal::AssertHelper::operator=() #2 0x00000048024a autofill::(anonymous namespace)::AutofillManagerTestDelegateImpl::DidPreviewFormData() #3 0x0000018382dd autofill::mojom::AutofillDriverStubDispatch::Accept() #4 0x000003301871 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #5 0x0000033010d5 mojo::internal::MultiplexRouter::Accept() #6 0x0000032fc1e1 mojo::Connector::ReadSingleMessage() #7 0x0000032fc881 mojo::Connector::ReadAllAvailableMessages() #8 0x0000032f914a mojo::SimpleWatcher::OnHandleReady() #9 0x000002f0aa4c base::debug::TaskAnnotator::RunTask() #10 0x000002f1eac7 base::MessageLoop::RunTask() #11 0x000002f1ef78 base::MessageLoop::DoWork() #12 0x000002f95c69 base::MessagePumpLibevent::Run() #13 0x000002f3bca5 base::RunLoop::Run() #14 0x00000291c3d1 content::MessageLoopRunner::Run() #15 0x000000475a97 autofill::AutofillInteractiveIsolationTest_SimpleCrossSiteFill_Test::RunTestOnMainThread() #16 0x000002912063 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #17 0x0000025c0fbd ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #18 0x0000025bff3a ChromeBrowserMainParts::PreMainMessageLoopRun() #19 0x000001a251ef chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #20 0x0000010fae81 content::BrowserMainLoop::PreMainMessageLoopRun() #21 0x00000143bc57 content::StartupTaskRunner::RunAllTasksNow() #22 0x0000010f99e2 content::BrowserMainLoop::CreateStartupTasks() #23 0x0000010fd0c3 content::BrowserMainRunnerImpl::Initialize() #24 0x0000010f77c4 content::BrowserMain() #25 0x000002598a98 content::ContentMainRunnerImpl::Run() #26 0x0000040557bf service_manager::Main() #27 0x000002596d34 content::ContentMain() #28 0x000002911c7f content::BrowserTestBase::SetUp() #29 0x0000025b01e6 InProcessBrowserTest::SetUp() BrowserTestBase received signal: Terminated. Backtrace: #0 0x000002f860bc base::debug::StackTrace::StackTrace() #1 0x000002912305 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fd56d29ccb0 <unknown> #3 0x7fd56d3646d3 epoll_wait #4 0x000002fb76ad epoll_dispatch #5 0x000002fb518c event_base_loop #6 0x000002f95c21 base::MessagePumpLibevent::Run() #7 0x000002f3bca5 base::RunLoop::Run() #8 0x00000291c3d1 content::MessageLoopRunner::Run() #9 0x00000048099d autofill::AutofillInteractiveTestBase::SendKeyToPopupAndWait() #10 0x000000475ad5 autofill::AutofillInteractiveIsolationTest_SimpleCrossSiteFill_Test::RunTestOnMainThread() #11 0x000002912063 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #12 0x0000025c0fbd ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #13 0x0000025bff3a ChromeBrowserMainParts::PreMainMessageLoopRun() #14 0x000001a251ef chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #15 0x0000010fae81 content::BrowserMainLoop::PreMainMessageLoopRun() #16 0x00000143bc57 content::StartupTaskRunner::RunAllTasksNow() #17 0x0000010f99e2 content::BrowserMainLoop::CreateStartupTasks() #18 0x0000010fd0c3 content::BrowserMainRunnerImpl::Initialize() #19 0x0000010f77c4 content::BrowserMain() #20 0x000002598a98 content::ContentMainRunnerImpl::Run() #21 0x0000040557bf service_manager::Main() #22 0x000002596d34 content::ContentMain() #23 0x000002911c7f content::BrowserTestBase::SetUp() #24 0x0000025b01e6 InProcessBrowserTest::SetUp() #25 0x000000777f5d testing::Test::Run() #26 0x000000778b80 testing::TestInfo::Run() #27 0x000000779097 testing::TestCase::Run() #28 0x000000784577 testing::internal::UnitTestImpl::RunAllTests() #29 0x0000007840ed testing::UnitTest::Run() #30 0x000002efaaa1 base::TestSuite::Run() #31 0x000000571023 InteractiveUITestSuiteRunner::RunTestSuite() #32 0x000002918fa9 content::LaunchTests() #33 0x0000025aab23 LaunchChromeTests() #34 0x000000570fad main #35 0x7fd56d287f45 __libc_start_main #36 0x00000044134a _start
,
May 18 2018
Thanks for reporting. No need to Cc people, triaging should work.
,
May 18 2018
,
May 18 2018
,
May 18 2018
Merging this bug with another related flake in Issue 843863
,
May 18 2018
Issue 843863 has been merged into this issue.
,
May 18 2018
I'm going to disable DeletingFrameUnderSuggestion on Chrome OS, just like SimpleCrossSiteFill. It's unclear what's causing this flakiness, but it looks like a recent regression on 5/16/18: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=All%2FAutofillInteractiveIsolationTest.SimpleCrossSiteFill%2F1 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=All%2FAutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion%2F1 It's possible this flakiness relates back to Issue 834369 , but I hope not... It's also worth investigating if other non-isolation autofill interactive_ui_tests (eg AutofillInteractiveTest) are similarly flaky: https://bugs.chromium.org/p/chromium/issues/list?can=2&q=AutofillInteractiveTest Fabio, can you take the bug from here?
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30acd3cb0a21e8892105a9d0eae6203b6b66a24e commit 30acd3cb0a21e8892105a9d0eae6203b6b66a24e Author: Mike Wasserman <msw@chromium.org> Date: Fri May 18 21:14:54 2018 Disable flaky AutofillInteractiveIsolationTest on Chrome OS This is flaky on Chrome OS, just like the other isolation fixture. See the bug (and merged issues) for additional details. TBR=ftirelo@chromium.org,xiyuan@chromium.org Bug: 843935 Change-Id: Ic0170a4df9e5f9fe3b75c14d65718edef4001a94 Reviewed-on: https://chromium-review.googlesource.com/1066617 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#560036} [modify] https://crrev.com/30acd3cb0a21e8892105a9d0eae6203b6b66a24e/chrome/browser/autofill/autofill_interactive_uitest.cc
,
May 19 2018
Detected 12 new flakes for test/step "All/AutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTgsSBUZsYWtlIkNBbGwvQXV0b2ZpbGxJbnRlcmFjdGl2ZUlzb2xhdGlvblRlc3QuRGVsZXRpbmdGcmFtZVVuZGVyU3VnZ2VzdGlvbi8xDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
May 19 2018
Findit identified the culprit r559213 with confidence 70.0% in the config "tryserver.chromium.chromiumos / linux-chromeos-rel" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKdAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzgyNDIvaW50ZXJhY3RpdmVfdWlfdGVzdHMvUVd4c0wwRjFkRzltYVd4c1NXNTBaWEpoWTNScGRtVkpjMjlzWVhScGIyNVVaWE4wTGtSbGJHVjBhVzVuUm5KaGJXVlZibVJsY2xOMVoyZGxjM1JwYjI0dk1RPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 19 2018
,
May 19 2018
Could this be due to https://chromium-review.googlesource.com/1060278 ?
,
May 19 2018
msw@: Thanks! I will take this from here. rogerm@: Possibly. I will check on Tuesday, since Monday is a corp holiday in Canada.
,
May 22 2018
Discussed offline with rogerm@ and it can be caused by the single click change. Some details on how to run the cros test on a linux machine for easier access: Add the following line to .gclient: target_os = ['chromeos'] Generate a new config: $ gn args out/rel-chromeos ffmpeg_branding = "ChromeOS" is_component_build = false is_debug = false proprietary_codecs = true strip_absolute_paths_from_debug_symbols = true target_os = "chromeos" use_goma = true use_vaapi = true Run as: $ autoninja -C out/rel-chromeos/ interactive_ui_tests && out/rel-chromeosd/interactive_ui_tests --gtest_filter=All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 --gtest_repeat=300 --gtest_break_on_failure
,
May 22 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/450d4a7d8c0437fad9af4e591b1190b9103e40c5 commit 450d4a7d8c0437fad9af4e591b1190b9103e40c5 Author: Roger McFarlane <rogerm@chromium.org> Date: Tue May 22 23:59:48 2018 [autofill] Fix flaky interatcive/isolation test The test has an inherent race between triggering the showing of suggestions and starting the loop to wait for notification that the suggestions have been shown. The test was asserting that the loop had been started before quiting. Removed this (racily invalid) insertion. Also switched over to use base::RunLoop instead of using content::MessageLoopRunner (per crbug.com/668707), to remove additional flakiness. Bug: 843935 , 668707 Change-Id: I3084b64697983b64c34fedd26e690d419807f2a8 Reviewed-on: https://chromium-review.googlesource.com/1069531 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560842} [modify] https://crrev.com/450d4a7d8c0437fad9af4e591b1190b9103e40c5/chrome/browser/autofill/autofill_interactive_uitest.cc
,
May 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, May 17 2018