New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843931 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: May 2018
Cc:
justincohen@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Incognito NTP can be scrolled even if it has enough space

Project Member Reported by gambard@chromium.org, May 17 2018 
iPhone X only

What steps will reproduce the problem?
(1) Open a NTP
(2) Scroll Up

What is the expected result?
The content of the page should come back to the original place

What happens instead?
The content is in a different position. The toolbar is also changing its color.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d762728bab96990b6850e1edb2cab49c9cf97a0

commit 5d762728bab96990b6850e1edb2cab49c9cf97a0
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri May 18 08:20:07 2018

Fix Open New Incognito Tab animation

This CL fixes the Open New Incognito Tab animation when the
BrowserContainerViewController is in fullscreen.
It is also fixing the animation for the iPhone X.

Bug: 688259,  836730 , 819811,  843931 ,  844013 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I298811b90b42122ff2f805f7888d2d5ff750c2b8
Reviewed-on: https://chromium-review.googlesource.com/1061528
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559837}
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/snapshots/snapshot_generator.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.h
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/features.mm
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/public/features.h
[modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/web_state/ui/crw_web_controller.mm

Comment 2 by gambard@chromium.org, May 18 2018

Status: Fixed (was: Assigned)

Comment 3 by vbarig...@chromium.org, May 22 2018

Status: Verified (was: Fixed)
Verified on chrome canary version 68.0.3436.0 on iPhone X with iOS 11.3.1, 11.4 beta 6 following the steps mentioned in comment #0.  The incognito content of NTP gets back to its original place after scroll up.  Looks good.
►

Sign in to add a comment