New issue
Advanced search Search tips

Issue 843927 link

Starred by 2 users
Status: Fixed
Owner:
tkent@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Merge common logic of name_style_converter.py and name_utilities.py

Project Member Reported by tkent@chromium.org, May 17 2018 
Chrome Version: ToT
OS: All

- third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
- third_party/blink/renderer/build/scripts/name_utilities.py

Both of them were made to convert names to various styles.  E.g. "HTMLElement" -> "html_element".  They have different algorithms to tokenize input names.  We should consolidate them.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01aff28497492f15d0b2cf03353cac8e91412422

commit 01aff28497492f15d0b2cf03353cac8e91412422
Author: Kent Tamura <tkent@chromium.org>
Date: Fri May 18 04:56:41 2018

Make SmartTokenizer a simple function.

It doesn't need to be a class. A function is enough.
This CL has no behavior changes.

Bug:  843927 
Change-Id: I20f8029b4b4a9b4254a7baeaa1e304bc053fb3f2
Reviewed-on: https://chromium-review.googlesource.com/1065474
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559802}
[modify] https://crrev.com/01aff28497492f15d0b2cf03353cac8e91412422/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/01aff28497492f15d0b2cf03353cac8e91412422/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
Project Member

Comment 2 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/576f913309419f2ca70c234e09832023491b0736

commit 576f913309419f2ca70c234e09832023491b0736
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 21 00:43:01 2018

name_style_converter: Fix handling of lowercase-only tokens.

tokenize_name() didn't recognize a sequence of lowercase letters as a
token, and MATCHING_EXPRESSION didn't contain SPECIAL_TOKENS. So,
'isHTMLDocument' was split to 'isHTML' and 'Document'. In order to avoid
such issues,

- MATCHING_EXPRESSION should contain SPECIAL_TOKENS
- It should also capture lowercase-only tokens, uppercase-only tokens,
  and digits-only tokens.

MATCHING_EXPRESSION is renamed to _TOKEN_RE, and it's now a compiled
regular expression.
This is a preparation to marge name_style_converter and name_utilities.

Bug:  843927 
Change-Id: I0630c7dae4a0e01013ce6dc6948f663d04c47d0c
Reviewed-on: https://chromium-review.googlesource.com/1065830
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560214}
[modify] https://crrev.com/576f913309419f2ca70c234e09832023491b0736/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/576f913309419f2ca70c234e09832023491b0736/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
Project Member

Comment 3 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95c3874dccc011fff0246ac71a178e575ee6c9bb

commit 95c3874dccc011fff0246ac71a178e575ee6c9bb
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 21 03:43:22 2018

name_style_converter: Ignore characters not matched to _TOKEN_RE.

The new behavior matches to name_utilities.py.
This CL has no behavior changes because the current users of
name_style_converter never pass names with such characters.

Bug:  843927 
Change-Id: I8eeafb71ec85bb1a0f92eff317fb07eb2dc373ff
Reviewed-on: https://chromium-review.googlesource.com/1065959
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560224}
[modify] https://crrev.com/95c3874dccc011fff0246ac71a178e575ee6c9bb/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/95c3874dccc011fff0246ac71a178e575ee6c9bb/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
Project Member

Comment 4 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fdbb63033e2936ed9ad9e91cab5ec06090a57fa

commit 1fdbb63033e2936ed9ad9e91cab5ec06090a57fa
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 21 05:31:11 2018

name_style_converter: Accept 'd' for a suffix for a single digit.

'3d' should be recognized as a single token as well as '3D'.
tokenize_name() will handle 'matrix3d' in CSSValueKeywords.json5.

Bug:  843927 
Change-Id: I409751a6dd19a02c457895a15b32680ca36f2dd7
Reviewed-on: https://chromium-review.googlesource.com/1065754
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560232}
[modify] https://crrev.com/1fdbb63033e2936ed9ad9e91cab5ec06090a57fa/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/1fdbb63033e2936ed9ad9e91cab5ec06090a57fa/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
Project Member

Comment 5 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba635bce0bc572700536901ba1bc62861568afda

commit ba635bce0bc572700536901ba1bc62861568afda
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 21 07:45:57 2018

Blink: name_utilities.py uses name_style_converter.py.

Replace split_name() in name_utilities.py with tokenize_name() defined
in name_style_converter.py.

split_name() had upper_first_letter() call. It had no effect because the
first letter of split_name() result was always converted to something.
join_names() just joins tokenized names, but join_names() result is
always tokenized and its first letter is always converted to something.

upper_first_letter() converts None input to ''.  It happens only for
functions with @naming_style. So this CL adds None-check to
naming_style().

Bug:  843927 
Change-Id: I3b705fa46a8f04c37d2b571bfe2011dfe1ceaf3e
Reviewed-on: https://chromium-review.googlesource.com/1067298
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560242}
[modify] https://crrev.com/ba635bce0bc572700536901ba1bc62861568afda/third_party/blink/renderer/build/scripts/name_utilities.py
[modify] https://crrev.com/ba635bce0bc572700536901ba1bc62861568afda/third_party/blink/renderer/build/scripts/scripts.gni
Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7

commit a8b924c41d683aa4ee5eb9cc770ae3606322b7f7
Author: Kent Tamura <tkent@chromium.org>
Date: Tue May 22 05:16:49 2018

name_style_converter: Add NameStyleConverter.to_lower_camel_case(), and replace lower_first() with it.

In order to reduce usage of name_utilities.ACRONYMS, this CL introduces
NameStyleConverter.to_lower_camel_case(), and replaces existing usage
of lower_first() with to_lower_camel_case().

* name_style_converter.py:
 - Add to_lower_camel_case().
 - Fix tokenization of 'Acceralated2dCanvas'. '2d' not at the end of a
   name should be recognized as a token.

* make_event_factory.py and make_style_builder.py:
  Remove 'lower_first' filter.  It's not used.

* make_runtime_features.py, internal_runtime_flags.h.tmpl,
  internal_runtime_flags.idl.tmpl, origin_trials.cc.tmpl,
  origin_trials.h.tmpl:
  Use NameStyleConveter.to_lower_camel_case().

* name_utilities.py:
  Remove lower_first().

Bug:  843927 
Change-Id: I2ab4d90773f625afff1ab2a245ffd0d5cff8d4e9
Reviewed-on: https://chromium-review.googlesource.com/1068300
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560487}
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/make_event_factory.py
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/make_runtime_features.py
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/make_style_builder.py
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/name_utilities.py
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/templates/internal_runtime_flags.h.tmpl
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/templates/internal_runtime_flags.idl.tmpl
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/templates/origin_trials.cc.tmpl
[modify] https://crrev.com/a8b924c41d683aa4ee5eb9cc770ae3606322b7f7/third_party/blink/renderer/build/scripts/templates/origin_trials.h.tmpl
Project Member

Comment 7 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b84c603ee0f7240ff8a025ee2d4da4269af30ac1

commit b84c603ee0f7240ff8a025ee2d4da4269af30ac1
Author: Kent Tamura <tkent@chromium.org>
Date: Wed May 23 01:59:30 2018

name_style_converter: Replace upper_first() usage with to_upper_camel_case().

* name_style_converter.py:
  to_upper_camel_case() supports cases where the first token is a
  lowercased-acronym.
  Add 'DNS', 'XSS', and 'FE' to SPECIAL_TOKENS.

* json5_generator.py, and make_runtime_features.py:
  Move 'tokenized_name' initialization from make_runtime_features.py to
  json5_generator.py because it is used in many places.

* make_element_factory.py, make_element_type_helpers.py,
  make_internal_settings.py, make_settings.py,
  internal_settings_generated.cc.tmpl,
  internal_settings_generated.h.tmpl,
  internal_settings_generated.idl.tmpl, settings_macros.h.tmpl:
  Use 'tokenized_name.to_upper_camel_case()' instead of upper_first
  filter.

* name_utilities.py: Remove upper_first() and ACRONYMS.

Bug:  843927 
Change-Id: Icb297c5cb820a7e98e09a69f63a27a8b89f7c836
Reviewed-on: https://chromium-review.googlesource.com/1068772
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560890}
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/json5_generator.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/make_element_factory.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/make_element_type_helpers.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/make_internal_settings.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/make_runtime_features.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/make_settings.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/name_utilities.py
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/templates/internal_settings_generated.cc.tmpl
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/templates/internal_settings_generated.h.tmpl
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/templates/internal_settings_generated.idl.tmpl
[modify] https://crrev.com/b84c603ee0f7240ff8a025ee2d4da4269af30ac1/third_party/blink/renderer/build/scripts/templates/settings_macros.h.tmpl
Project Member

Comment 8 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47769d57f76da7219f00bd7568a3fc79a2eb3e39

commit 47769d57f76da7219f00bd7568a3fc79a2eb3e39
Author: Kent Tamura <tkent@chromium.org>
Date: Fri May 25 05:46:49 2018

json5_generator: Make 'name' field a NameStyleConverter object

The 'name' field of entries produced by Json5File.load_from_files() was
a str, and this CL makes it a NameStyleConverter object.  The original
string is accessible via |entry['name'].original|, and
|str(entry['name'])|.  This will make filter setup simpler because we
don't need to provide filters for naming style conversion.

* name_style_converter.py:
 - Provide |original| getter, and __str__().
 - Provide __lt__() for sort().
 - Provide __eq__() for groupby().
  Some Jinja2 templates use built-in sort and groupby filters, and it's
  hard to specify key object in templates.

* json5_generator.py
  Sets entry['name'] to a NameStyleConverter object, and remove
  entry['tokenized_name'].

* DEPS
  Clean stale *.pyc in blink/renderer/build/scripts too. Some buildbots
  has media_feature_symbol.pyc in build/scripts/core/css/.

* Other files
 - If code requires a string name, access entry['name'].original.
 - Use entry.name instead of entry.tokenized_name


Bug:  843927 
Change-Id: Ic47c90c51c8e88f08307a41b052ecfce971a4545
Reviewed-on: https://chromium-review.googlesource.com/1068575
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561780}
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/DEPS
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/core/css/make_css_value_keywords.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/core/css/make_style_shorthands.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/json5_generator.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/keyword_utils.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_computed_style_base.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_css_primitive_value_unit_trie.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_css_property_names.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_css_value_id_mappings.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_element_factory.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_element_lookup_trie.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_element_type_helpers.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_event_factory.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_internal_settings.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_names.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_origin_trials.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_qualified_names.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_runtime_features.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/make_settings.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/media_feature_symbol.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/name_utilities.py
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/internal_runtime_flags.h.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/internal_runtime_flags.idl.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/internal_settings_generated.cc.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/internal_settings_generated.h.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/internal_settings_generated.idl.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/make_qualified_names.cc.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/origin_trials.cc.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/origin_trials.h.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/templates/settings_macros.h.tmpl
[modify] https://crrev.com/47769d57f76da7219f00bd7568a3fc79a2eb3e39/third_party/blink/renderer/build/scripts/update_css_ranking.py
Project Member

Comment 10 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d843375f103729ee2cbb3caf285b74486169a821

commit d843375f103729ee2cbb3caf285b74486169a821
Author: Kent Tamura <tkent@chromium.org>
Date: Fri May 25 10:11:55 2018

blinkbuild: Remove class_member_name() in name_utilities.py.

Add to_class_data_member() to NameStyleConverter, and use it instead
of class_member_name().

* make_runtime_features.py:
 - Remove feature.class_member_name. Replace its usage with
   {{feature.name.to_class_data_member()}}.
 - Introduce _data_member_name() and feature.data_member_name.
   'is_{{snake_case_name}}_enabled_' is used repeatedly in the python
   code and the templates.

This CL doesn't change generated C++ code.

Bug:  843927 
Change-Id: I3b80460a05b155278a5f0bf46bddf0051a768457
Reviewed-on: https://chromium-review.googlesource.com/1073173
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561821}
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/core/style/computed_style_fields.py
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/make_computed_style_base.py
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/make_runtime_features.py
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/name_utilities.py
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/templates/runtime_enabled_features.cc.tmpl
[modify] https://crrev.com/d843375f103729ee2cbb3caf285b74486169a821/third_party/blink/renderer/build/scripts/templates/runtime_enabled_features.h.tmpl
Project Member

Comment 12 by bugdroid1@chromium.org, May 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4d6a465ced2eb54ed06540873009fae89dbcc57

commit d4d6a465ced2eb54ed06540873009fae89dbcc57
Author: Kent Tamura <tkent@chromium.org>
Date: Mon May 28 02:09:17 2018

blinkbuild: Remove external users of upper_camel_case().

Replaces them with NameStyleConverter.to_upper_camel_case(), and makes
upper_camel_case() private.

This CL is just a code simplification, and doesn't change any generated code.

Bug:  843927 
Change-Id: I1f251b51f5bfc3888381b1ec51ca5323f03085dd
Reviewed-on: https://chromium-review.googlesource.com/1074790
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562162}
[modify] https://crrev.com/d4d6a465ced2eb54ed06540873009fae89dbcc57/third_party/blink/renderer/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/d4d6a465ced2eb54ed06540873009fae89dbcc57/third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py
[modify] https://crrev.com/d4d6a465ced2eb54ed06540873009fae89dbcc57/third_party/blink/renderer/build/scripts/core/css/parser/templates/at_rule_descriptors.cc.tmpl
[modify] https://crrev.com/d4d6a465ced2eb54ed06540873009fae89dbcc57/third_party/blink/renderer/build/scripts/core/css/parser/templates/at_rule_descriptors.h.tmpl
[modify] https://crrev.com/d4d6a465ced2eb54ed06540873009fae89dbcc57/third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_base.py
[modify] https://crrev.com/d4d6a465ced2eb54ed06540873009fae89dbcc57/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property_subclass.cc.tmpl
[modify] https://crrev.com/d4d6a465ced2eb54ed06540873009fae89dbcc57/third_party/blink/renderer/build/scripts/name_utilities.py
Project Member

Comment 13 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6725c1fdf0183cca1ca58666e50f21bf51028a17

commit 6725c1fdf0183cca1ca58666e50f21bf51028a17
Author: Kent Tamura <tkent@chromium.org>
Date: Tue May 29 05:48:23 2018

blinkbuild: Remove name_utilities.class_name().

Introduce NameStyleConverter.to_class_name(), and replace class_name()
usages with to_class_name().

Also, add a docstring to NameStyleConverter.to_class_data_member().

Bug:  843927 
Change-Id: I3ebd7b1e7be9ef31a1d723f30a2429d9ab7e7fcb
Reviewed-on: https://chromium-review.googlesource.com/1074799
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562345}
[modify] https://crrev.com/6725c1fdf0183cca1ca58666e50f21bf51028a17/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/6725c1fdf0183cca1ca58666e50f21bf51028a17/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
[modify] https://crrev.com/6725c1fdf0183cca1ca58666e50f21bf51028a17/third_party/blink/renderer/build/scripts/core/style/computed_style_fields.py
[modify] https://crrev.com/6725c1fdf0183cca1ca58666e50f21bf51028a17/third_party/blink/renderer/build/scripts/make_computed_style_base.py
[modify] https://crrev.com/6725c1fdf0183cca1ca58666e50f21bf51028a17/third_party/blink/renderer/build/scripts/name_utilities.py
Project Member

Comment 14 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4491c3d8af12196c3abfab46df601b8dd24aafe0

commit 4491c3d8af12196c3abfab46df601b8dd24aafe0
Author: Kent Tamura <tkent@chromium.org>
Date: Tue May 29 09:18:35 2018

blinkbuild: Remove method_name() in name_utilities.py

Introduce NameStyleConveter.to_function_name(), and replace usage of
method_name() with to_function_name().

* join_names() is also removed. This CL makes join_names() unnecessary.

* method_name() converted 'domContentLoadedEventFired' in
  CoreProbes.pidl to 'DomContentLoadedEventFired,' however
  NameStyleConverter converts it to 'DOMContentLoadedEventFired'. This
  CL updates C++ code for it.

Bug:  843927 
Change-Id: I90a59111824ea76c690c2f809f1acb4bdbac6efd
Reviewed-on: https://chromium-review.googlesource.com/1075913
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562374}
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/build/scripts/core/style/computed_style_fields.py
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/build/scripts/make_computed_style_base.py
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/build/scripts/make_instrumenting_probes.py
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/build/scripts/name_utilities.py
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/core/inspector/inspector_dom_agent.h
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
[modify] https://crrev.com/4491c3d8af12196c3abfab46df601b8dd24aafe0/third_party/blink/renderer/core/inspector/inspector_page_agent.h
Project Member

Comment 15 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de2836883aaf67fd4e667a36cb33450be5183624

commit de2836883aaf67fd4e667a36cb33450be5183624
Author: Kent Tamura <tkent@chromium.org>
Date: Wed May 30 08:22:30 2018

blinkbuild: Use NameStyleConverter in enum_for_css_keyword(), enum_for_css_property(), and enum_for_css_property_alias().

We'd like to reduce the usage of _upper_camel_case().

enum_for_css_keyword() and enum_for_css_property() accept a str or a
NameStyleConveter instance as an argument because their multiple
callsites have only strings, and creating NameStyleConveter in callsites
would make the code noisy.

The generated code won't be changed at all.

Bug:  843927 
Change-Id: I64f7bb81f24a0d5caab1d81b477fcaab561bca9f
Reviewed-on: https://chromium-review.googlesource.com/1077714
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562760}
[modify] https://crrev.com/de2836883aaf67fd4e667a36cb33450be5183624/third_party/blink/renderer/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/de2836883aaf67fd4e667a36cb33450be5183624/third_party/blink/renderer/build/scripts/core/css/make_css_value_keywords.py
[modify] https://crrev.com/de2836883aaf67fd4e667a36cb33450be5183624/third_party/blink/renderer/build/scripts/name_utilities.py
Project Member

Comment 16 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e90d4fdc744a954c98fa9de5f46266211687b189

commit e90d4fdc744a954c98fa9de5f46266211687b189
Author: Kent Tamura <tkent@chromium.org>
Date: Wed May 30 13:57:41 2018

blinkbuild: Migrate enum_value_name() from name_utilities to NameStyleConverter.

Bug:  843927 
Change-Id: I7a4c7912ae535ce9afa2a2a0df433eea185a9cfd
Reviewed-on: https://chromium-review.googlesource.com/1078407
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562810}
[modify] https://crrev.com/e90d4fdc744a954c98fa9de5f46266211687b189/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter.py
[modify] https://crrev.com/e90d4fdc744a954c98fa9de5f46266211687b189/third_party/blink/renderer/build/scripts/blinkbuild/name_style_converter_test.py
[modify] https://crrev.com/e90d4fdc744a954c98fa9de5f46266211687b189/third_party/blink/renderer/build/scripts/core/css/css_properties.py
[modify] https://crrev.com/e90d4fdc744a954c98fa9de5f46266211687b189/third_party/blink/renderer/build/scripts/core/style/computed_style_fields.py
[modify] https://crrev.com/e90d4fdc744a954c98fa9de5f46266211687b189/third_party/blink/renderer/build/scripts/make_css_value_id_mappings.py
[modify] https://crrev.com/e90d4fdc744a954c98fa9de5f46266211687b189/third_party/blink/renderer/build/scripts/name_utilities.py
Project Member

Comment 17 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c063048b7aff8376742f0c9eb2e6e225d843d86

commit 1c063048b7aff8376742f0c9eb2e6e225d843d86
Author: Kent Tamura <tkent@chromium.org>
Date: Thu May 31 01:16:40 2018

blinkbuild: Remove external usage of upper_first_letter().

NameStyleConverter.to_function_name() works well for
make_media_features.py. Also, rename the filter from
'upper_first_letter' to 'to_function_name'.

Makes upper_first_letter() private.

Bug:  843927 
Change-Id: Id3cedbbc66f01c839d2ef2a4294073aae5896222
Reviewed-on: https://chromium-review.googlesource.com/1080109
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563102}
[modify] https://crrev.com/1c063048b7aff8376742f0c9eb2e6e225d843d86/third_party/blink/renderer/build/scripts/core/css/make_media_features.py
[modify] https://crrev.com/1c063048b7aff8376742f0c9eb2e6e225d843d86/third_party/blink/renderer/build/scripts/core/css/templates/media_features.h.tmpl
[modify] https://crrev.com/1c063048b7aff8376742f0c9eb2e6e225d843d86/third_party/blink/renderer/build/scripts/name_utilities.py
Project Member

Comment 18 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/298d4c60d094e96422a09e535da17649dd8136ac

commit 298d4c60d094e96422a09e535da17649dd8136ac
Author: Kent Tamura <tkent@chromium.org>
Date: Thu May 31 04:04:20 2018

blinkbuild: Remove dead code in name_utilities.py

snake_case() and enum_type_name() are not used. Remove them and their
dependent.

Bug:  843927 
Change-Id: If93fcb25e1cf26299ed06dc65a9de387c528b15b
Reviewed-on: https://chromium-review.googlesource.com/1080351
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563147}
[modify] https://crrev.com/298d4c60d094e96422a09e535da17649dd8136ac/third_party/blink/renderer/build/scripts/json5_generator.py
[modify] https://crrev.com/298d4c60d094e96422a09e535da17649dd8136ac/third_party/blink/renderer/build/scripts/name_utilities.py

Comment 19 by tkent@chromium.org, May 31 2018

Owner: tkent@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment