New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843924 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 578890



Sign in to add a comment

Tab inserted after removing character on Ozone/Wayland build

Project Member Reported by je_julie.kim@chromium.org, May 17 2018

Issue description

Chrome Version: 68.0.343.0
OS: Linux

What steps will reproduce the problem?
(1) Run Chromium with Ozone/Wayland after building with use_ozone and ozone_platform_wayland.
'chrome --ozone-platform=wayland --in-process-gpu'
(2) Go to https://cs.chromium.org
(3) Type any word to search at input.
(4) After page is moved, Move focus to url bar.
(5) Press tab key at url bar.

What is the expected result?
-Move focus only without removing current text at search input

What happens instead?
-Character from search input disappears and tab is inserted

 
Description: Show this description
It's related to Issue 578890.

Comment 3 by msi...@igalia.com, May 17 2018

Blocking: 578890

Comment 4 by msi...@igalia.com, May 17 2018

Cc: msi...@igalia.com toniki...@igalia.com
Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62190d478a25e16cf3f18326026a0d1bd8b63c64

commit 62190d478a25e16cf3f18326026a0d1bd8b63c64
Author: Julie Jeongeun Kim <jkim@igalia.com>
Date: Tue May 29 03:50:12 2018

Added stopped_propagation condition at input_method_minial

It added event->stopped_propagation() condition at input_method_minimal
to avoid inserting character when stopped_propagation is set while
DispatchKeyEventPostIME is working. input_method_minial works on Ozone
with wayland.
It also added input_method_minimal_unittests.cc and introduced
'InputMethodMinimalTest.StopPropagationTest' to verify that
character's not inserted to text input when the event is
set with stopped_propagation.

TEST=ui_base_unittests

Bug:  843924 , 578890
Change-Id: I2d8f6d408a04cd7affd8089157b7b0efa07379d5
Reviewed-on: https://chromium-review.googlesource.com/1063417
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#562332}
[modify] https://crrev.com/62190d478a25e16cf3f18326026a0d1bd8b63c64/ui/base/BUILD.gn
[modify] https://crrev.com/62190d478a25e16cf3f18326026a0d1bd8b63c64/ui/base/ime/input_method_minimal.cc
[add] https://crrev.com/62190d478a25e16cf3f18326026a0d1bd8b63c64/ui/base/ime/input_method_minimal_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment