New issue
Advanced search Search tips

Issue 843922 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

[Autotest] Add basic hotwording test audio_AudioBasicHotwording

Project Member Reported by paulhsia@chromium.org, May 17 2018

Issue description

crbug tracker for basic hotwording tests for chromeos devices with hotwording chip.

The changes will include hotwording tests with
1. Normal mode
2. Suspend mode

and can be run by
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP audio_AudioBasicHotwording.suspend

Please check the design doc from the following link:
https://docs.google.com/document/d/149bE3Jv6WwUkOM0s9k9i5yuf0ccLGrpH59TNS1NDyoU/edit?ts=5af3e7f5#

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7025b4b3caae6f3ef8520783ba31a5f6e2e3962a

commit 7025b4b3caae6f3ef8520783ba31a5f6e2e3962a
Author: paulhsia <paulhsia@chromium.org>
Date: Tue Aug 14 12:55:27 2018

[autotest] Add new function to generate hotwording command

Add function listen_cmd to generate command
cras_test_client --listen_f capture_file.raw --rate NUM --num_channels
NUM --duration Num --block_size NUM

Add an end of line to the end of file.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I2295ba71e348c55de1c3fd1cf4086a430d25f994
Reviewed-on: https://chromium-review.googlesource.com/1065601
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/7025b4b3caae6f3ef8520783ba31a5f6e2e3962a/client/cros/audio/cras_utils.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/826a3b2677d5a5e0fc36339495bcf84141284e2e

commit 826a3b2677d5a5e0fc36339495bcf84141284e2e
Author: paulhsia <paulhsia@chromium.org>
Date: Tue Aug 14 12:55:28 2018

[autotest] Add class Listener to control hotwording process

An object support __init__, start, stop and cleanup hotwording process control.
Return ListenerError when it fail to stop.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: Ic8b576a5a61e21bc5239d940fa018b6e6dfd8ef3
Reviewed-on: https://chromium-review.googlesource.com/1065602
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/826a3b2677d5a5e0fc36339495bcf84141284e2e/client/cros/multimedia/audio_facade_native.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/411cda115b583c347f250ab7b98f06b750488511

commit 411cda115b583c347f250ab7b98f06b750488511
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Aug 15 19:54:59 2018

[autotest] Add listening methods to AudioFacadeNative

The change is for native function call on CrOS host.
Add codes in __init__ and cleanup for initialization and destruction.
Add start_listening and stop_listening methods using Listener object to
control hotwording process with given format.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I1a645a36ca44c3dca0ee749bc6d212d0820eef80
Reviewed-on: https://chromium-review.googlesource.com/1065603
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/411cda115b583c347f250ab7b98f06b750488511/client/cros/multimedia/audio_facade_native.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7f8196772d7d46bdd0e480b1f999d494256b8738

commit 7f8196772d7d46bdd0e480b1f999d494256b8738
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Aug 15 23:37:34 2018

[autotest] Add listening methods to AudioFacadeRemoteAdapter

The change is for remote control to CrOS host.
Add start_listening and stop_listening methods to control remote CrOS
host hotwording functions.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I808a933896b81e6fac2d15dbacdd0a78936d0c1a
Reviewed-on: https://chromium-review.googlesource.com/1065604
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/7f8196772d7d46bdd0e480b1f999d494256b8738/server/cros/multimedia/audio_facade_adapter.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/dbfeb0fb731ccac5c16664bcfd5632827c66173d

commit dbfeb0fb731ccac5c16664bcfd5632827c66173d
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Aug 16 03:35:49 2018

[autotest] Create a CrOS widget type for hotwording

Create a new widget type - CrosHotwordingWidgetHandler for hotwording
function with start_listening and stop_listening methods.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I3c2d66ff2fb2a7454fb3a57b968500ca9997cfa9
Reviewed-on: https://chromium-review.googlesource.com/1065605
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/dbfeb0fb731ccac5c16664bcfd5632827c66173d/client/cros/chameleon/audio_widget.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bd912432dc2e40d1ca8b2278eb5a67b1a0b474de

commit bd912432dc2e40d1ca8b2278eb5a67b1a0b474de
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Aug 16 03:35:49 2018

[autotest] Expose listening interfaces in AudioInputWidget

Expose start_listening and stop_listening interfaces in AudioInputWidget
for hotwording.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I9bcabd98c274ff732764df343c779ed491af354b
Reviewed-on: https://chromium-review.googlesource.com/1065606
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/bd912432dc2e40d1ca8b2278eb5a67b1a0b474de/client/cros/chameleon/audio_widget.py

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2452d6a054618f10b7ff91b72df6ade13db25afd

commit 2452d6a054618f10b7ff91b72df6ade13db25afd
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Aug 16 03:35:50 2018

[autotest] Add CrosId and return CrosWidgetHandler corresponds to it

CrosId type - HOTWORDING is a kind of sink port.
Return CrosHotwordingWidgetHandler in _create_cros_handler.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: Ie799a9f774738aa85121cd2604dc937825223260
Reviewed-on: https://chromium-review.googlesource.com/1065607
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/2452d6a054618f10b7ff91b72df6ade13db25afd/client/cros/chameleon/chameleon_audio_ids.py
[modify] https://crrev.com/2452d6a054618f10b7ff91b72df6ade13db25afd/client/cros/chameleon/chameleon_audio_helper.py

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6de88712dc731e305351c6892f174e0e7dd7697d

commit 6de88712dc731e305351c6892f174e0e7dd7697d
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Aug 16 03:35:50 2018

[autotest] Add test data contains hotword

The test data contains hotword - "Ok google" generated by google
translate. The file format is two-channel raw data with each sample
being a signed 16-bit integer in little-endian with sampling rate 48000
samples/sec.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I25038b78a07d40b2966ca632b7f775ac2d2237dd
Reviewed-on: https://chromium-review.googlesource.com/1065608
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/6de88712dc731e305351c6892f174e0e7dd7697d/client/cros/audio/audio_test_data.py
[add] https://crrev.com/6de88712dc731e305351c6892f174e0e7dd7697d/client/cros/audio/hotword_16.raw

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4dd269f2ce7ad64b8aa46877baafbbd6e30bd2a0

commit 4dd269f2ce7ad64b8aa46877baafbbd6e30bd2a0
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Aug 16 03:35:51 2018

[autotest] Add hotwording check function for CrosHost

Add hotwording check function in audio_test_utils for a given CrosHost
object.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I5e3ce8011d61744057fab395b42527184aeea31d
Reviewed-on: https://chromium-review.googlesource.com/1065609
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/4dd269f2ce7ad64b8aa46877baafbbd6e30bd2a0/client/cros/chameleon/audio_test_utils.py

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7d131d871a88abcbe770f62863eeac2c162e79b9

commit 7d131d871a88abcbe770f62863eeac2c162e79b9
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Aug 16 20:14:43 2018

[autotest] Add audio_AudioBasicHotwording test class

Add audio_AudioBasicHotwording object in audio_AudioBasicHotwording.py
for testing hotwording function on a DUT. The test is trying to play a
golden file after playing a hotword when the hotwording function is
opened, and check if the result match the golden file's frequency.

Flag suspend is to control whether the DUT will suspend before playing
the hotword.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I00bc5499ad803b0e40dffe2eaddbc7800752a8be
Reviewed-on: https://chromium-review.googlesource.com/1065711
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[add] https://crrev.com/7d131d871a88abcbe770f62863eeac2c162e79b9/server/site_tests/audio_AudioBasicHotwording/audio_AudioBasicHotwording.py

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5963e8170df238fc9a667e2928be323b05b3c4d9

commit 5963e8170df238fc9a667e2928be323b05b3c4d9
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Aug 16 20:14:43 2018

[autotest] Add audio_AudioBasicHotwording test control files

These tests will fail if the captured audio after hotword does not match
the original file.
control: For hotwording test without suspending DUT before playing hotword.
control.suspend: For hotwording test with suspending DUT before playing
                 hotword.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I0b1774d595f301145e2064610822265cf6d7e840
Reviewed-on: https://chromium-review.googlesource.com/1065712
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[add] https://crrev.com/5963e8170df238fc9a667e2928be323b05b3c4d9/server/site_tests/audio_AudioBasicHotwording/control.suspend
[add] https://crrev.com/5963e8170df238fc9a667e2928be323b05b3c4d9/server/site_tests/audio_AudioBasicHotwording/control

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e46e0e36ce57457c1dd715b0acb4afafcfdbd0f8

commit e46e0e36ce57457c1dd715b0acb4afafcfdbd0f8
Author: Paul Hsia <paulhsia@google.com>
Date: Fri Aug 17 18:18:04 2018

autotest-server-tests: Add audio_AudioBasicHotwording

Add audio_AudioBasicHotwording into autotest-server-tests ebuild.

BUG=chromium:843922
TEST=none
CQ-DEPEND=CL:1065712

Change-Id: Ib83dc7cb6163d69382aaec557b4f020716d1c56b
Reviewed-on: https://chromium-review.googlesource.com/1177295
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/e46e0e36ce57457c1dd715b0acb4afafcfdbd0f8/chromeos-base/autotest-server-tests/autotest-server-tests-9999.ebuild

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f9e687349e15bf16ef744adf9cb0f90c59fd58ab

commit f9e687349e15bf16ef744adf9cb0f90c59fd58ab
Author: Paul Hsia <paulhsia@chromium.org>
Date: Tue Sep 04 14:29:43 2018

[autotest] Expose start_playback_with_path in AudioOutputWidget

To support quicker continues playback, we do the following changes:

1. Return remote_playback_path in set_playback_data function.
2. Expose function start_playback_with_path and use the path returned from
   set_playback_data to start a playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I9933bb4302150354108c0d22694be79682f7d819
Reviewed-on: https://chromium-review.googlesource.com/1203691
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/f9e687349e15bf16ef744adf9cb0f90c59fd58ab/client/cros/chameleon/audio_widget.py

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1540b82e22a925b4e3021218d0bc4057d618482

commit b1540b82e22a925b4e3021218d0bc4057d618482
Author: Paul Hsia <paulhsia@chromium.org>
Date: Tue Sep 04 14:29:44 2018

[autotest] Use start_playback_with_path in hotwording test

Function set_playback_data need times to setup.
To start two continuous playbacks with little delay, we let the test use
start_playback_with_path instead of start_playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I996d4fbf489fd66db6bb18c43a42541c0a550a55
Reviewed-on: https://chromium-review.googlesource.com/1203692
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/b1540b82e22a925b4e3021218d0bc4057d618482/client/cros/audio/audio_test_data.py
[modify] https://crrev.com/b1540b82e22a925b4e3021218d0bc4057d618482/server/site_tests/audio_AudioBasicHotwording/audio_AudioBasicHotwording.py

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f9e687349e15bf16ef744adf9cb0f90c59fd58ab

commit f9e687349e15bf16ef744adf9cb0f90c59fd58ab
Author: Paul Hsia <paulhsia@chromium.org>
Date: Tue Sep 04 14:29:43 2018

[autotest] Expose start_playback_with_path in AudioOutputWidget

To support quicker continues playback, we do the following changes:

1. Return remote_playback_path in set_playback_data function.
2. Expose function start_playback_with_path and use the path returned from
   set_playback_data to start a playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I9933bb4302150354108c0d22694be79682f7d819
Reviewed-on: https://chromium-review.googlesource.com/1203691
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/f9e687349e15bf16ef744adf9cb0f90c59fd58ab/client/cros/chameleon/audio_widget.py

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1540b82e22a925b4e3021218d0bc4057d618482

commit b1540b82e22a925b4e3021218d0bc4057d618482
Author: Paul Hsia <paulhsia@chromium.org>
Date: Tue Sep 04 14:29:44 2018

[autotest] Use start_playback_with_path in hotwording test

Function set_playback_data need times to setup.
To start two continuous playbacks with little delay, we let the test use
start_playback_with_path instead of start_playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I996d4fbf489fd66db6bb18c43a42541c0a550a55
Reviewed-on: https://chromium-review.googlesource.com/1203692
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/b1540b82e22a925b4e3021218d0bc4057d618482/client/cros/audio/audio_test_data.py
[modify] https://crrev.com/b1540b82e22a925b4e3021218d0bc4057d618482/server/site_tests/audio_AudioBasicHotwording/audio_AudioBasicHotwording.py

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f9e687349e15bf16ef744adf9cb0f90c59fd58ab

commit f9e687349e15bf16ef744adf9cb0f90c59fd58ab
Author: Paul Hsia <paulhsia@chromium.org>
Date: Tue Sep 04 14:29:43 2018

[autotest] Expose start_playback_with_path in AudioOutputWidget

To support quicker continues playback, we do the following changes:

1. Return remote_playback_path in set_playback_data function.
2. Expose function start_playback_with_path and use the path returned from
   set_playback_data to start a playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I9933bb4302150354108c0d22694be79682f7d819
Reviewed-on: https://chromium-review.googlesource.com/1203691
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/f9e687349e15bf16ef744adf9cb0f90c59fd58ab/client/cros/chameleon/audio_widget.py

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1540b82e22a925b4e3021218d0bc4057d618482

commit b1540b82e22a925b4e3021218d0bc4057d618482
Author: Paul Hsia <paulhsia@chromium.org>
Date: Tue Sep 04 14:29:44 2018

[autotest] Use start_playback_with_path in hotwording test

Function set_playback_data need times to setup.
To start two continuous playbacks with little delay, we let the test use
start_playback_with_path instead of start_playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I996d4fbf489fd66db6bb18c43a42541c0a550a55
Reviewed-on: https://chromium-review.googlesource.com/1203692
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/b1540b82e22a925b4e3021218d0bc4057d618482/client/cros/audio/audio_test_data.py
[modify] https://crrev.com/b1540b82e22a925b4e3021218d0bc4057d618482/server/site_tests/audio_AudioBasicHotwording/audio_AudioBasicHotwording.py

Labels: M-70 Merge-Request-70
Need to merge the last two changes back to m70 to make the test complete.
These are changes for only test lab tests.
Labels: -Merge-Request-70 Merge-Approved-70
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 7

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cfdcd834cf9df1288125893c38f4627840cd3adf

commit cfdcd834cf9df1288125893c38f4627840cd3adf
Author: Paul Hsia <paulhsia@chromium.org>
Date: Fri Sep 07 02:25:32 2018

[autotest] Expose start_playback_with_path in AudioOutputWidget

To support quicker continues playback, we do the following changes:

1. Return remote_playback_path in set_playback_data function.
2. Expose function start_playback_with_path and use the path returned from
   set_playback_data to start a playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I9933bb4302150354108c0d22694be79682f7d819
Previous-Reviewed-on: https://chromium-review.googlesource.com/1203691
(cherry picked from commit d0a77519317f28ea4ff9655425cf5173d4551f90)
Reviewed-on: https://chromium-review.googlesource.com/1212682
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>
Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/cfdcd834cf9df1288125893c38f4627840cd3adf/client/cros/chameleon/audio_widget.py

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fb88b86b2baf19029cfb51dff5375c2fe1527b8c

commit fb88b86b2baf19029cfb51dff5375c2fe1527b8c
Author: Paul Hsia <paulhsia@chromium.org>
Date: Fri Sep 07 02:31:56 2018

[autotest] Use start_playback_with_path in hotwording test

Function set_playback_data need times to setup.
To start two continuous playbacks with little delay, we let the test use
start_playback_with_path instead of start_playback.

BUG=chromium:843922
TEST=Apply full patch set to run
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording
test_that --fast --debug --args="chameleon_host=CHAMELEON_IP" DUT_IP
audio_AudioBasicHotwording.suspend

Change-Id: I996d4fbf489fd66db6bb18c43a42541c0a550a55
Previous-Reviewed-on: https://chromium-review.googlesource.com/1203692
(cherry picked from commit b8b760c800ec728e1e7c5173d84deca0bab5fa9a)
Reviewed-on: https://chromium-review.googlesource.com/1212683
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>
Commit-Queue: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/fb88b86b2baf19029cfb51dff5375c2fe1527b8c/client/cros/audio/audio_test_data.py
[modify] https://crrev.com/fb88b86b2baf19029cfb51dff5375c2fe1527b8c/server/site_tests/audio_AudioBasicHotwording/audio_AudioBasicHotwording.py

Project Member

Comment 23 by sheriffbot@chromium.org, Sep 10

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 24 by sheriffbot@chromium.org, Sep 14

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70 Merge-Merged
Owner: ka...@chromium.org
The tests is stable on eve and kevin now.
And we removed the hotwording label from samus since we don't want to support it's hotwording function.

Hi Kalin,

We want the test to cover more types of DSP hotwording device.

Could you help us to setup to following two boards:
soraka: KBL-Y DSP hotwording device
nami: KBL-U DSP hotwording device
for the tests?

The tests need these labels:
chameleon, audio_board, audio_box, hotwording
and we want to see them in perbuild.

Thanks!
Cc: conradlo@chromium.org

Sign in to add a comment