New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843919 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: May 2018
Cc:
ajha@chromium.org
r...@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 832173



Sign in to add a comment

Regression: Accept and Reject buttons are seen too close to each other in Pair Bluetooth device overlay

Project Member Reported by rkalavakuntla@chromium.org, May 17 2018 
Chrome Version:68.0.3431.0/10682.0.0 dev-channel Daisy,Candy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build >> From ubertray, enable Bluetooth
(2)Pair with a device to connect and observe the Accept and Reject buttons when passkey is seen.

Actual: Accept and Reject buttons are seen too close to each other
Expected: There should be a reasonable margin between them 

This is Regression Issue as same is working fine in 68.0.3405.0/10631.0.0 

Note: Issue is not seen in Linux,Windows OS

Attached the screenshot for reference..
Actual.jpg
2.2 MB View Download
Actual.mp4
6.4 MB View Download
Expected.jpg
2.3 MB View Download

Comment 1 by dpa...@chromium.org, May 17 2018

Blocking: 832173
Status: Available (was: Untriaged)
Need to add some spacing between the buttons, now that both buttons have a background. Note that the spacing is same as before, it just happens that they did not have background before.

Comment 2 by steve...@chromium.org, May 17 2018

Components: UI>Settings
Labels: Hotlist-MD-Settings-Bluetooth

Comment 3 by steve...@chromium.org, May 17 2018

Cc: r...@chromium.org

Comment 4 by dpa...@chromium.org, May 17 2018

Owner: dpa...@chromium.org
Status: Started (was: Available)

Comment 5 by dpa...@chromium.org, May 17 2018 

Candidate fix at https://chromium-review.googlesource.com/#/c/chromium/src/+/1064607. Attaching before/after screenshots.
spacing_before.png
15.0 KB View Download
spacing_after.png
14.2 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97d7c17fcc6439ff69b5c80da59c1a096a7b3790

commit 97d7c17fcc6439ff69b5c80da59c1a096a7b3790
Author: dpapad <dpapad@chromium.org>
Date: Thu May 17 23:07:25 2018

WebUI Bluetooth dialog: Fix action buttons spacing after MD Refresh.

Bug:  843919 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2c2857742286cc9e0928fe5e3bfa583648b546b5
Reviewed-on: https://chromium-review.googlesource.com/1064607
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559724}
[modify] https://crrev.com/97d7c17fcc6439ff69b5c80da59c1a096a7b3790/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html

Comment 7 by dpa...@chromium.org, May 17 2018

Status: Fixed (was: Started)

Comment 8 by dpa...@chromium.org, May 22 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
►

Sign in to add a comment