Guess this is fixed by https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1063326

Now that we pin depot_tools in V8, we need to get this rolled into V8.

Hmm, no. After updating my local depot tools, I can't update the pinned depot tools with setdep anymore:

machenbach@malumi:~/v8/v8 algkwjeglkwejg $ gclient setdep -r v8/third_party/depot_tools@23a358764dd8cd61e7d6efe086fb51c78ae0ac9b
Traceback (most recent call last):
  File "/usr/local/google/home/machenbach/tools/depot_tools/gclient.py", line 2949, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/machenbach/tools/depot_tools/gclient.py", line 2935, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/machenbach/tools/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/machenbach/tools/depot_tools/gclient.py", line 2808, in CMDsetdep
    gclient_eval.SetRevision(local_scope, name, value)
  File "/usr/local/google/home/machenbach/tools/depot_tools/gclient_eval.py", line 791, in SetRevision
    _UpdateRevision(gclient_dict['deps'], dep_name, new_revision)
  File "/usr/local/google/home/machenbach/tools/depot_tools/gclient_eval.py", line 750, in _UpdateRevision
    dep_node = dep_dict.GetNode(dep_key)
AttributeError: 'dict' object has no attribute 'GetNode'

The problem seems to be introduced by:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1058375

Uh, also raw `gclient` seems to auto-update depot tools o_O. But calling gclient.py doesn't. Since we currently call gclient we might actually not run on the pinned revision in V8.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/24c1d35a32c9a76475081a0c548db525e803dcd0

commit 24c1d35a32c9a76475081a0c548db525e803dcd0
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu May 17 09:41:55 2018

[build] Revert pinned depot_tools to unbreak auto-roller

TBR=sergiyb@chromium.org

Bug:  chromium:843917 
Change-Id: I1b7efb5dd4fa7a87c84cc1bbfa7780a8600aad03
Reviewed-on: https://chromium-review.googlesource.com/1063750
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53227}
[modify] https://crrev.com/24c1d35a32c9a76475081a0c548db525e803dcd0/DEPS

I heard from Sergiy that updating depot tools on gclient might be WAI. I'll investigate how to disable the update when using the pinned version.

Hmm, look like the file .disable_auto_update needs to be created in depot tools root...

CL for disabling auto-update:
https://chromium-review.googlesource.com/c/v8/v8/+/1063971

After this, our auto-roll should get fixed again. But the root cause still remains and needs fixing in depot tools.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5783c63942246109f46269156a0611505ee7350d

commit 5783c63942246109f46269156a0611505ee7350d
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu May 17 11:11:08 2018

[tools] Make sure pinned depot_tools don't auto-update

TBR=sergiyb@chromium.org

Bug:  chromium:843917 
Change-Id: I7f1c6d7979a76a9573f0673a09444eba26297f05
Reviewed-on: https://chromium-review.googlesource.com/1063971
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53229}
[modify] https://crrev.com/5783c63942246109f46269156a0611505ee7350d/DEPS

This didn't solve it. The V8 release script is executed from a V8 inside a Chromium checkout. We also don't call the (expensive) runhooks for Chromium, so the auto-update is not disabled.

But since Chromium's depot tools version contains the bug, we'd need to rewind depot_tools there first.

Best would be to just fix the bug and we roll manually until then.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d169622f83d82eb5f5203d921bc3209b3e2a12b4

commit d169622f83d82eb5f5203d921bc3209b3e2a12b4
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu May 17 12:09:59 2018

Revert "[release] Switch auto-roller to gclient setdep"

This reverts commit a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9.

Reason for revert:
Temporarily use legacy method until  https://crbug.com/843917  is fixed.

Original change's description:
> [release] Switch auto-roller to gclient setdep
> 
> NOTRY=true
> 
> Bug:  chromium:828745 
> Change-Id: I051f57893937796e01f0b823f1050dd36e0fbfd9
> Reviewed-on: https://chromium-review.googlesource.com/997556
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52385}

TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org

NOTRY=true

Bug:  chromium:843917 
Change-Id: I69978ba55ffa5996101e1d31bdf10364b7ef273f
Reviewed-on: https://chromium-review.googlesource.com/1064130
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53230}
[modify] https://crrev.com/d169622f83d82eb5f5203d921bc3209b3e2a12b4/tools/release/auto_roll.py
[modify] https://crrev.com/d169622f83d82eb5f5203d921bc3209b3e2a12b4/tools/release/test_scripts.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/4727c64750e84e093a8046384fb0d1f0fbb2b339

commit 4727c64750e84e093a8046384fb0d1f0fbb2b339
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu May 17 15:52:23 2018

gclient: Fix getdep and setdep and add tests.

Bug:  843917 , 839925
Change-Id: I84e52c95fc91d67375d4d954018f057561896914
Reviewed-on: https://chromium-review.googlesource.com/1064005
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339/tests/gclient_smoketest.py
[modify] https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339/gclient.py
[modify] https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339/recipes/trigger_recipe_roller.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/90e61da1c6b2e6d229bb6d79d1a09d901513d9e6

commit 90e61da1c6b2e6d229bb6d79d1a09d901513d9e6
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu May 17 16:24:31 2018

Reland "[release] Switch auto-roller to gclient setdep"

This reverts commit d169622f83d82eb5f5203d921bc3209b3e2a12b4.

Reason for revert: setdep bug should be fixed

Original change's description:
> Revert "[release] Switch auto-roller to gclient setdep"
> 
> This reverts commit a9f5dd30e4f9cfd2a4c39f8b903b8b6a414691e9.
> 
> Reason for revert:
> Temporarily use legacy method until  https://crbug.com/843917  is fixed.
> 
> Original change's description:
> > [release] Switch auto-roller to gclient setdep
> > 
> > NOTRY=true
> > 
> > Bug:  chromium:828745 
> > Change-Id: I051f57893937796e01f0b823f1050dd36e0fbfd9
> > Reviewed-on: https://chromium-review.googlesource.com/997556
> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#52385}
> 
> TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org
> 
> NOTRY=true
> 
> Bug:  chromium:843917 
> Change-Id: I69978ba55ffa5996101e1d31bdf10364b7ef273f
> Reviewed-on: https://chromium-review.googlesource.com/1064130
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53230}

TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org

Change-Id: Ia70dc1df7e25e0c8ffd3fafeb97830b5d5f87336
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:843917 
Reviewed-on: https://chromium-review.googlesource.com/1064413
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53238}
[modify] https://crrev.com/90e61da1c6b2e6d229bb6d79d1a09d901513d9e6/tools/release/auto_roll.py
[modify] https://crrev.com/90e61da1c6b2e6d229bb6d79d1a09d901513d9e6/tools/release/test_scripts.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bfca97905e72e616739cb9f96d28f8294d3eee8

commit 3bfca97905e72e616739cb9f96d28f8294d3eee8
Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 17 19:47:13 2018

Roll src/third_party/depot_tools/ 23a358764..b496b6a05 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/23a358764dd8..b496b6a0570b

$ git log 23a358764..b496b6a05 --date=short --no-merges --format='%ad %ae %s'
2018-05-17 ehmaldonado gclient: Fix roll-dep.
2018-05-17 ehmaldonado gclient: Fix getdep and setdep and add tests.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:839925, chromium:843917 ,chromium:839925


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I21d57efe8cacbd4c2f7c8043e4ab71d0f38ee747
Reviewed-on: https://chromium-review.googlesource.com/1064735
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559646}
[modify] https://crrev.com/3bfca97905e72e616739cb9f96d28f8294d3eee8/DEPS

Guess this is fixed? Filed  issue 845425  for remaining V8 side auto-roller problems.