media_unittests AndroidVideoDecodeAcceleratorTest and MediaCodecVideoDecoderTest fail under CFI |
|||
Issue descriptionExample failing build: https://ci.chromium.org/buildbot/chromium.clang/ToTAndroidCFI/2023
,
May 17 2018
Hmm, seems https://chromium-review.googlesource.com/c/chromium/src/+/1062802 was supposed to fix this, but the failures remain on the bot.
,
May 17 2018
Ah, I didn't see the other failures. I'll fix those shortly.
,
May 17 2018
This turned out to be a bit involved, but CL here https://chromium-review.googlesource.com/c/chromium/src/+/1064534
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edcd62b757dd40cdf54db1eedddff32f58fe515c commit edcd62b757dd40cdf54db1eedddff32f58fe515c Author: Dale Curtis <dalecurtis@chromium.org> Date: Thu May 17 22:54:49 2018 Fix Android MediaCodec decoders to work without proprietary codecs. This extends both the MediaCodecVideoDecoder and AndroidVideoDecodeAccelerator tests to run for all codecs supported by the current build configuration (vp8, vp9, h264 in best case). This is a vast expansion in test coverage, which is great, but it also reveals a few weird spots in MCVD. E.g., there are several of the H264 tests which seem like they should work for all codecs. BUG= 843914 TEST=it's all tests! Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4d6abfcb071a9cf1f2f0bd5a2f3ceab2fdd11c18 Reviewed-on: https://chromium-review.googlesource.com/1064534 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559717} [modify] https://crrev.com/edcd62b757dd40cdf54db1eedddff32f58fe515c/media/gpu/android/android_video_decode_accelerator.cc [modify] https://crrev.com/edcd62b757dd40cdf54db1eedddff32f58fe515c/media/gpu/android/android_video_decode_accelerator.h [modify] https://crrev.com/edcd62b757dd40cdf54db1eedddff32f58fe515c/media/gpu/android/android_video_decode_accelerator_unittest.cc [modify] https://crrev.com/edcd62b757dd40cdf54db1eedddff32f58fe515c/media/gpu/android/media_codec_video_decoder_unittest.cc
,
May 17 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, May 17 2018