New issue
Advanced search Search tips

Issue 843899 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Timeout in pdf_codec_fax_fuzzer

Project Member Reported by ClusterFuzz, May 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4578707336069120

Fuzzer: libFuzzer_pdf_codec_fax_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_codec_fax_fuzzer
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=551565:551569

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4578707336069120

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 17 2018

Cc: dsinclair@chromium.org jam@chromium.org brucedaw...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Components: Internals>Plugins>PDF
Owner: thestig@chromium.org
Project Member

Comment 4 by ClusterFuzz, May 19 2018

ClusterFuzz has detected this issue as fixed in range 559868:559894.

Detailed report: https://clusterfuzz.com/testcase?key=4578707336069120

Fuzzer: libFuzzer_pdf_codec_fax_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_codec_fax_fuzzer
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=551565:551569
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559868:559894

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4578707336069120

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, May 19 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 4578707336069120 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/588a35b1db1e03721af62a02ec910c7583b7118a

commit 588a35b1db1e03721af62a02ec910c7583b7118a
Author: Lei Zhang <thestig@chromium.org>
Date: Mon May 21 18:36:08 2018

Avoid indexing into std::vector inside a tight loop.

In CCodec_FaxDecoder::v_GetNextLine(), a fixed size vector often needs
to be inverted. Doing so without checking bounds on every access makes a
big difference in non-optimized builds.

BUG= chromium:843899 

Change-Id: Iecc0a3da22631a289745245563dab7a7c3c458d0
Reviewed-on: https://pdfium-review.googlesource.com/32744
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/588a35b1db1e03721af62a02ec910c7583b7118a/core/fxcodec/codec/fx_codec_fax.cpp

Not sure why CF decided this was fixed, but the CL in comment 6 will definitely help.
Project Member

Comment 8 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac188f989ae0c71071b85c0ac8ae43cd3a6d751d

commit ac188f989ae0c71071b85c0ac8ae43cd3a6d751d
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon May 21 20:21:27 2018

Roll src/third_party/pdfium/ 9e1739218..588a35b1d (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/9e1739218386..588a35b1db1e

$ git log 9e1739218..588a35b1d --date=short --no-merges --format='%ad %ae %s'
2018-05-21 thestig Avoid indexing into std::vector inside a tight loop.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:843899 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I10c2e2c3c6719e434ac71065ad6c9dce0f236443
Reviewed-on: https://chromium-review.googlesource.com/1067539
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560344}
[modify] https://crrev.com/ac188f989ae0c71071b85c0ac8ae43cd3a6d751d/DEPS

Sign in to add a comment