New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843895 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Please update ChromeOS Emoji font file to support Unicode 11.0 and update the palette to use the same categories/ordering as Android

Project Member Reported by ijpedowitz@google.com, May 17 2018

Issue description

Chrome Version: 66.0.3359.158 (Official Build) (64-bit)
OS: ChromeOS

What steps will reproduce the problem?
(1)  Try to use Emoji on Pixelbook

What is the expected result?
Full Unicode 10.0 Emoji (as Unicode 11.0 doesn't come out until June)

What happens instead?
Doesn't seem to be the latest emoji in all cases.
 
Cc: shuchen@chromium.org chengong@chromium.org
Components: UI>Input>VirtualKeyboard
Labels: OS-Chrome
Owner: wuyingbing@chromium.org
Status: Assigned (was: Untriaged)
Owner: omrilio@chromium.org
shuchen, I don't know how to update font file.
It's not IME issue. ChromeOS need to update system font file.

Omrilio, could you help to route to the right team please?
Owner: xiy...@chromium.org
+Xiyuan, do you know who would handle that?

Comment 4 by xiy...@chromium.org, May 17 2018

Owner: js...@chromium.org
Is this NotoColorEmoji.ttf as part of noto family?

jshin@ helped us to add/update fonts on chromeos. Maybe he knows.
I believe this is the NotoColorEmoji.ttf, but not 100% sure.

Please keep in mind, this isn't about simply updating the font file itself (although that's the first step).  You'll need to update the emoji picker to also display/categorize the new emoji, and I propose you mirror the display/categorization that Android uses.

Comment 6 by js...@chromium.org, May 17 2018

Yes, it's NotoColorEmoji.ttf. It's updated last fall so that it should support Unicode 10. 

The only difference between Android and Chrome OS should be 'Hamburger' and a couple of other emojis. 



Comment 7 by js...@chromium.org, May 17 2018

Cc: dougfelt@google.com
 ijpedowitz@ :  Has NotoColorEmoji at github been updated with the pallette as used in Android ?

Ok. https://github.com/googlei18n/noto-emoji/commits/master

There have been quite many changes since last fall. Will update to the latest from there. 

If there's anything newer than that, let me know. 
Cc: siyamed@google.com
Hey Jessica, it looks like you mostly answered your own question in comment 7, correct?

Doug/Siyamed, do you know when the next update to github would be, or would it be safe for Jessica to take what's there now?

At a higher level, how can we make sure ChromeOS tracks the update to the font file on a regular basis?  Shouldn't every ChromeOS release pull in the most recent font file?

Also, please note, that I don't think this is as straightforward as pulling in just the font file.  That will fix display issues, but the keyboard will still need the emoji added to the proper categories, or categories added which are missing, so users can select them.  I think the categories and bucketing should match Android.
Cc: shend@chromium.org
Labels: NewUI
The new UI needs to implement this eventually, so adding NewUI label.
Cc: sebg@google.com
Summary: Please update ChromeOS Emoji font file to support Unicode 11.0 and update the palette to use the same categories/ordering as Android (was: Please update ChromeOS Emoji font file to support Unicode 10.0 and update the palette to use the same categories/ordering as Android)
Friendly ping?  Can the emoji font file at least be updated while the rest of the work like picker is done orthogonally?  Emoji such as bagel 🥯 and lobster 🦞 don't show on ChromeOS.
Labels: -Pri-3 Pri-2
Sorry for the delay. 

> At a higher level, how can we make sure ChromeOS tracks the update to the font file on a regular basis?  Shouldn't every ChromeOS release pull in the most recent font file?

Well, CrOS had been getting the latest Noto fonts in general much earlier than Android until early this year (usually as soon as we have new versions).  This particular issue has been delayed because of changes on my side. 

In the meantime, I'll just update Noto Color Emoji (putting aside other Noto fonts update which I meant to bundle up with emoji font update) for now.  
No worries!

>Well, CrOS had been getting the latest Noto fonts in general much earlier than Android until early this year (usually as soon as we have new versions).  This particular issue has been delayed because of changes on my side. 

Ah, thanks for sharing!  What were the other changes blocking this?  Just curious.

>In the meantime, I'll just update Noto Color Emoji (putting aside other Noto fonts update which I meant to bundle up with emoji font update) for now.  

Awesome, thank you!!!  Do you think this can be done in M72?  Do you know when the palette and other updates would be done?
> Do you know when the palette and other updates would be done?

I'm sorry that I don't even know who's in charge of that part. 
Cc: marekj@google.com
>https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1387603 is a CL. 

w00t, thanks!!!!

>I'm sorry that I don't even know who's in charge of that part. 

Would this bug be routed to someone who can sort that out, once the font change is merged?  This bug included reporting that as well.
shuchen@ : do you know who handles emoji palette / input ? 

In the meantime, my CL is blocked by https://bugs.chromium.org/p/chromium/issues/detail?id=910430#c10  . 
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/43fedfc460fc3d6c5045ac8727b97951371da07f

commit 43fedfc460fc3d6c5045ac8727b97951371da07f
Author: Jungshik Shin <jshin@chromium.org>
Date: Sun Dec 23 22:46:10 2018

Update NotoCJK and Noto Color Emoji

1. Update Noto Sans CJK to 2.0 released in November:

   * New character support (CJK Ext. G : a small subet via IDS)
   * Hong Kong glyph variant support
   * Noto Serif CJK parity

   For details, see
   https://blogs.adobe.com/CCJKType/2018/11/shsans-v2-technical-tidbits.html

   size change:
      55578120 => 60176916: 4,598,796  bytes increase

2. Update Noto Color Emoji to the latest (20180823; hash=07ad7f0f4dc1)

   * Unicode 11.0 Emoji support
   * A few glyph design changes

   size change:
      7792004 <= 7253060 : 538,944 bytes increase.

Other noto fonts will be updated in a follow-up CL. It's likely to
introduce variational fonts to CrOS now that fontconfig was updated
to support variational fonts.

BUG=chromium:843895, chromium:917343 
TEST=emerge works fine.
TEST=https://unicode.org/emoji/charts/full-emoji-list.html and search for  (recently added emojis)
Change-Id: Ie78ad84527e9cddbd4f96259c547e218589f86b3
Reviewed-on: https://chromium-review.googlesource.com/1387603
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/43fedfc460fc3d6c5045ac8727b97951371da07f/media-fonts/notofonts/notofonts-20180823.ebuild
[delete] https://crrev.com/d69ea3b654d921a0372f181f3ac15ceb0c2c1c6a/media-fonts/notofonts/notofonts-20171026-r1.ebuild
[rename] https://crrev.com/43fedfc460fc3d6c5045ac8727b97951371da07f/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1-r35.ebuild
[add] https://crrev.com/43fedfc460fc3d6c5045ac8727b97951371da07f/media-fonts/noto-cjk/noto-cjk-20181130-r1.ebuild
[modify] https://crrev.com/43fedfc460fc3d6c5045ac8727b97951371da07f/media-fonts/noto-cjk/Manifest
[add] https://crrev.com/43fedfc460fc3d6c5045ac8727b97951371da07f/media-fonts/notofonts/notofonts-20180823-r1.ebuild
[modify] https://crrev.com/43fedfc460fc3d6c5045ac8727b97951371da07f/media-fonts/notofonts/Manifest
[rename] https://crrev.com/43fedfc460fc3d6c5045ac8727b97951371da07f/media-fonts/noto-cjk/noto-cjk-20181130.ebuild
[delete] https://crrev.com/d69ea3b654d921a0372f181f3ac15ceb0c2c1c6a/media-fonts/noto-cjk/noto-cjk-20170501-r1.ebuild

Cc: js...@chromium.org
Owner: ----
The latest Noto Color Emoji is checked in for the trunk. 

Virtual kbd update has to be done by somebody else. I don't know who's in charge of that. 


Labels: -Type-Bug Type-Feature
Owner: pcovell@chromium.org
Assigning to Paul for triage. I don't think this is on our OKRs, so we can probably make it Available?

Sign in to add a comment