TabManager.ForegroundedOrClosed doesn't have SequenceId |
||
Issue descriptionChrome Version: M65+ OS: Chrome What steps will reproduce the problem? (1) Dremel or read ukm logs for pairing TabMetrics and ForegroundedOrClosed events. What is the result? ForegroundedOrClosed doesn't have SequenceId, so we have to rely on their original order in the report.ForegroundedOrClosed also shares the same SequenceId for easier pairing. What should happen instead? ForegroundedOrClosed also shares the same SequenceId for easier pairing.
,
May 17 2018
The NextAction date has arrived: 2018-05-17
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9570d33e23920f41132c01728f1440fa2d7c5de5 commit 9570d33e23920f41132c01728f1440fa2d7c5de5 Author: Charles Zhao <charleszhao@chromium.org> Date: Thu Jun 14 01:54:10 2018 Add sequence_id for TabManager.ForegroundedOrClosed event Bug: 843891 Change-Id: I7fba61c7a46a8d0b6a3dabdc37b9209510c9cb15 Reviewed-on: https://chromium-review.googlesource.com/1064651 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567089} [modify] https://crrev.com/9570d33e23920f41132c01728f1440fa2d7c5de5/chrome/browser/resource_coordinator/tab_activity_watcher_unittest.cc [modify] https://crrev.com/9570d33e23920f41132c01728f1440fa2d7c5de5/chrome/browser/resource_coordinator/tab_metrics_logger.cc [modify] https://crrev.com/9570d33e23920f41132c01728f1440fa2d7c5de5/chrome/browser/resource_coordinator/tab_metrics_logger_unittest.cc [modify] https://crrev.com/9570d33e23920f41132c01728f1440fa2d7c5de5/tools/metrics/ukm/ukm.xml
,
Aug 9
|
||
►
Sign in to add a comment |
||
Comment 1 by charleszhao@chromium.org
, May 17 2018