New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843873 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Hide Team Drives root for users with no Team Drives

Project Member Reported by sashab@chromium.org, May 17 2018

Issue description

Confirm that this behaviour is what we want, and if so, hide Team Drives root for users with no Team Drives.

If not, at least hide the Team Drives root for users who do not have the Team Drives feature enabled in Drive.
 
Yes! To confirm -

Team Drives feature should always be enabled on Chrome OS, but for users who do not have Team Drives, we should hide the root.

Comment 2 by sashab@chromium.org, May 18 2018

What about users that *do* have team drives enabled, but no team drives?
Should we show an empty root?
Interesting - I wonder if this use case is possible from a Team Drives configuration perspective? But, if so, we should hide the Team Drives root if the user is not a member of any Team Drives.

Comment 4 by sashab@chromium.org, May 21 2018

> Interesting - I wonder if this use case is possible from a Team Drives configuration perspective?

Enterprise users have Team Drives enabled by default, so I'm fairly sure the team drives root would appear in Google Drive (so you can create new team drives, for example) even though the user isn't a member of any team drives.
Cc: -s...@chromium.org slangley@chromium.org
Got it, thanks. Let's hide it even in this case as it's odd to have am empty Team Drives root in Files app when we don't support the ability to manage/add Team Drives.
Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47a3530af21aa843e9d3bc42cd027847c2dd6363

commit 47a3530af21aa843e9d3bc42cd027847c2dd6363
Author: Sasha Morrissey <sashab@chromium.org>
Date: Wed May 30 03:17:27 2018

Commented the code that hides the Team Drives root if there are no TDs

Commented the code that hides the Team Drives root if there are no Team
Drives in the Files app.

Bug:  843873 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I064f9e5ad558b87bf4d879bf16ec437fed563686
Reviewed-on: https://chromium-review.googlesource.com/1070013
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562717}
[modify] https://crrev.com/47a3530af21aa843e9d3bc42cd027847c2dd6363/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Comment 7 by sashab@chromium.org, May 30 2018

Status: Fixed (was: Assigned)

Sign in to add a comment