New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843869 link

Starred by 1 user
Status: Fixed
Owner:
alancutter@chromium.org
Closed: May 2018
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

PWA open in app window from incognito tab DCHECKs

Project Member Reported by alancutter@chromium.org, May 17 2018 
Chrome Version: 68
OS: Chrome OS

What steps will reproduce the problem?
(1) Visit https://fast-lute.glitch.me/
(2) Kebab menu > Install XXX...
(3) Open https://fast-lute.glitch.me/ in an incognito tab

What is the expected result?

"Kebab menu > Open in X..." should be disabled.

What happens instead?

The menu item is enabled, opens the tab in the app window and DCHECKs:
[153805:153805:0517/133604.266547:FATAL:application_launch.cc(447)] Check failed: !profile->IsOffTheRecord().
#0 0x7fc54ba1503c base::debug::StackTrace::StackTrace()                            
#1 0x7fc54b95ca6b logging::LogMessage::~LogMessage()             
#2 0x5637c9785ea3 ReparentWebContentsIntoAppBrowser()
#3 0x5637c9590fc7 chrome::BrowserCommandController::ExecuteCommandWithDisposition()
#4 0x7fc545ce0262 views::internal::MenuRunnerImpl::OnMenuClosed()
#5 0x7fc545cd0570 views::MenuController::ExitMenu()
#6 0x7fc545cd564f views::MenuController::ReallyAccept()   
#7 0x7fc545cd1ed4 views::MenuController::OnMouseReleased()
#8 0x7fc545d33b97 views::Widget::OnMouseEvent()                
#9 0x7fc545d50566 views::NativeWidgetAura::OnMouseEvent()
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/403cebbdd5132b65b7958ec0fff2f85d08055e34

commit 403cebbdd5132b65b7958ec0fff2f85d08055e34
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu May 17 05:22:45 2018

Disable PWA window popout menu option for incognito tabs

There's no UX on a PWA window to indicate incognito status, disable
the ability to get in this situation (also it DCHECKs).

Bug:  843869 
Change-Id: I6b48258dfbe118ea67aae9b9a5375b198eaa4e75
Reviewed-on: https://chromium-review.googlesource.com/1062991
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559426}
[modify] https://crrev.com/403cebbdd5132b65b7958ec0fff2f85d08055e34/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/403cebbdd5132b65b7958ec0fff2f85d08055e34/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Comment 2 by alancutter@chromium.org, May 17 2018

Status: Fixed (was: Started)
►

Sign in to add a comment