New issue
Advanced search Search tips

Issue 843865 link

Starred by 2 users
Status: Assigned
Owner:
zhangtiff@chromium.org
Cc:
seanmccullough@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: 10
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Establish initial Redux best practices doc with code examples

Project Member Reported by zhangtiff@chromium.org, May 17 2018 
Now that we have an Infra>UI component I feel comfortable starting to file a lot of bugs for work I want to do in this area. 

I estimate it'd be around 2-3 weeks of work to get a solid Redux best practices doc started. I'd have to learn Redux, apply Redux to a sufficiently complex frontend to test its usage, and study existing uses  of Redux/Redux+Polymer to improve our practices. After that, this doc will be iterated and improved on over time, but that's expected to take place over a longer timescale. 

I think I might have some time during FLT work to fit this in since at the moment, the frontend progress is a bit ahead of the backend.

Comment 1 by zhangtiff@chromium.org, May 17 2018

Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/674746e2e1c9713576102cd520163b446aa108b1

commit 674746e2e1c9713576102cd520163b446aa108b1
Author: Tiff Zhang <zhangtiff@google.com>
Date: Thu Jun 21 19:25:18 2018

Monorail: Add Redux as a dependency.

Bug:843865
Change-Id: Ibc31a80e854f36d7e0a478619e1a227d31aa15cd
Reviewed-on: https://chromium-review.googlesource.com/1110523
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/674746e2e1c9713576102cd520163b446aa108b1/appengine/monorail/package.json
[modify] https://crrev.com/674746e2e1c9713576102cd520163b446aa108b1/appengine/monorail/package-lock.json
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/484c938071b7c71207cff55b5ebae12e53d9d226

commit 484c938071b7c71207cff55b5ebae12e53d9d226
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Jun 22 18:33:25 2018

Monorail: Add Redux with Ajax requests for getting issue data in FLT.

Split off of: https://chromium-review.googlesource.com/c/infra/infra/+/1105410

Bug:843865
Change-Id: Ie8cf8123179970c363b0a9cfc1a488f384e44725
Reviewed-on: https://chromium-review.googlesource.com/1110939
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>

[add] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/flt/mr-approval-page/mr-issue-header-test.html
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/flt/mr-approval-page/mr-approval-page.html
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/flt/mr-approval-page/mr-issue-header.js
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/flt/mr-approval-page/mr-approval-page.js
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/bower.json
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/test/index.html
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/flt/mr-approval-page/mr-issue-header.html
[add] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/mixins/redux-mixin.html
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/templates/tracker/issue-approval-page.ezt
[modify] https://crrev.com/484c938071b7c71207cff55b5ebae12e53d9d226/appengine/monorail/elements/flt/mr-approval-page/mr-approval-page-test.html
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e30316bbfb22dc04e71f26a792e39de0a8f9e949

commit e30316bbfb22dc04e71f26a792e39de0a8f9e949
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Jun 22 18:44:45 2018

Monorail: Populate issue data with pRPC client + redux.

Demo: https://16116-76a2e4b-tainted-zhangtiff-dot-monorail-staging.appspot.com/p/chromium/issues/approval?id=12

Bug:843865
Change-Id: I8b2daa257193c92d2ee39a1b44c2a87cf6bc759e
Reviewed-on: https://chromium-review.googlesource.com/1105410
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>

[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/README.md
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/Makefile
[add] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/elements/mr-user-link/mr-user-link.js
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/elements/flt/mr-issue-details/mr-metadata.js
[add] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/elements/mr-user-link/mr-user-link.html
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/elements/flt/mr-issue-details/mr-metadata.html
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/crdx/chopsui/chops-timestamp.html
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/elements/flt/mr-edit-metadata/mr-edit-metadata.html
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/elements/mixins/redux-mixin.html
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/elements/flt/mr-edit-metadata/mr-edit-metadata.js
[modify] https://crrev.com/e30316bbfb22dc04e71f26a792e39de0a8f9e949/appengine/monorail/app.yaml
►

Sign in to add a comment