Issue metadata
Sign in to add a comment
|
Adding static initializers does not trigger any failures |
||||||||||||||||||
Issue descriptionIn bug 843858 , a CL added new static initializers. Years ago, this would have triggered a performance regression and bots would have gone red. This bug slipped by with no alerts AFAICT.
,
May 17 2018
About the `sizes` step not failing: that was filed in bug 832854 and duped into bug 832854 . There aren't specific performance benchmarks for static initializers. The chromium commit position for the change is 558576, so you can go to http://chromeperf.appspot.com/group_report?rev=558576 to look for performance regressions with the CL in range. It doesn't look like a regression was found. If there is a measurable performance regression from this CL, we could talk about adding a benchmark at chrome-benchmarking-request@, but I can't find evidence of one.
,
May 21 2018
@sullivan - Your first paragraph of #c2 confuses me. Bug 832854 was a case where `sizes` *did* fail, not a case where it didn't. So I don't think this is a dup?
,
May 21 2018
Ah okay, too many problems with the static initializers in sizes to keep up with.
,
Jan 10
Downgrading P2 issues unmodified for more than 6 months, which have no owner or component. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by dpranke@chromium.org
, May 17 2018