Static initializer in SkFontConfigInterface |
||
Issue descriptionhttps://skia-review.googlesource.com/127969 added a static initializer. Look at the difference between: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F64000%2F%2B%2Frecipes%2Fsteps%2Fsizes%2F0%2Fstdout and https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F64432%2F%2B%2Frecipes%2Fsteps%2Fsizes%2F0%2Fstdout # Static initializers in /b/c/b/linux_clobber/src/out/Release/chrome: # SkFontConfigInterface.cpp gFontConfigInterface # SkFontConfigInterface.cpp cc::DecodedDrawImage::~DecodedDrawImage() # SkFontConfigInterface.cpp __cxa_atexit@plt [registers a dtor to run at exit] # SkFontConfigInterface.cpp __dso_handle
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/753312c755fa824ef8ef78d71b4dd419051a25f2 commit 753312c755fa824ef8ef78d71b4dd419051a25f2 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 17 17:06:01 2018 Roll src/third_party/skia/ c06754b04..a33b67c36 (5 commits) https://skia.googlesource.com/skia.git/+log/c06754b0466e..a33b67c36bcd $ git log c06754b04..a33b67c36 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 bsalomon Rewrite GrQuad to use separate arrays of x and y values to be Sk4f friendly. 2018-05-17 timliang added basic texturing to metal sksl backend 2018-05-17 reed check path bounds before trying to shadow 2018-05-17 bungeman Remove static initializer to register destructor. 2018-05-16 bungeman Set margin for outer blur masks with no blur. Created with: roll-dep src/third_party/skia BUG= chromium:843858 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ib998a011def0bc981ae78506ca754e398ddb67aa Reviewed-on: https://chromium-review.googlesource.com/1064430 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559576} [modify] https://crrev.com/753312c755fa824ef8ef78d71b4dd419051a25f2/DEPS
,
May 17 2018
I patched in the fix locally and verified the SI is gone. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 17 2018