I'm not familiar with public session. I tried to keep the same behavior when I refactored immersive code, and let me know if it caused any regression.

-> rkc@ who probably know the correct behavior. (or know the person who knows)

I can provide you credentials to set up a public session. Public session UI should look more like regular sessions, where app windows have window bars with minimize/maximize/close buttons, because we support multiple windows. Instead, in public sessions apps currently don't have this frame, so they can't be moved and such.

Here's a screenshot of the Files and Calculator apps missing their header bars in a Public Session: https://i.imgur.com/RxwikAf.png

the windows are not fullsecreen. how it can be in immersive, but not fullscreened?

Looks like I misunderstood the comment when I refactored. I'll send a fix soon.

I don't know why it is, but it is.

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc?type=cs&q=file:chrome_native_app_window_views_aura_ash.cc+ispublicsession&sq=package:chromium&g=0&l=588

"  // Always use immersive mode in a public session."

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345d868020cf4af49d0cce035333205110227ef3

commit 345d868020cf4af49d0cce035333205110227ef3
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Wed Jun 20 05:56:46 2018

Use immersive for apps only in fullscreen state.

Looks like I misunderstood the comment when I refactored.

BUG= 843856 
TEST=covered by unittest

Change-Id: I6fb735472af25e833ef2a40f99bd0a26867da3fb
Reviewed-on: https://chromium-review.googlesource.com/1107214
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568743}
[modify] https://crrev.com/345d868020cf4af49d0cce035333205110227ef3/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/345d868020cf4af49d0cce035333205110227ef3/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/345d868020cf4af49d0cce035333205110227ef3/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc

should I merge back to 68?

It's low risk so let's try to merge it.

This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Yes, please approve this merge -- this bug is a serious usability issue in public sessions since app windows can't be moved, minimized, closed, etc. easily.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73d91cec956e36d181c01d6ea0dd0f31eb19a75f

commit 73d91cec956e36d181c01d6ea0dd0f31eb19a75f
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Jun 21 20:50:44 2018

Use immersive for apps only in fullscreen state.

Looks like I misunderstood the comment when I refactored.

BUG= 843856 
TEST=covered by unittest

Change-Id: I6fb735472af25e833ef2a40f99bd0a26867da3fb
Reviewed-on: https://chromium-review.googlesource.com/1107214
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568743}(cherry picked from commit 345d868020cf4af49d0cce035333205110227ef3)
Reviewed-on: https://chromium-review.googlesource.com/1110857
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#475}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/73d91cec956e36d181c01d6ea0dd0f31eb19a75f/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/73d91cec956e36d181c01d6ea0dd0f31eb19a75f/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/73d91cec956e36d181c01d6ea0dd0f31eb19a75f/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc

oshima, Olga has experienced this in 69.0.3497.35 dev. That's after your change. Is this the same issue?

Can't tell without details. I've tested iirc so it's likely an different cause.

Olga, could you please file a new bug with video?