New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843842 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Blocking:
issue 843511
issue 844261



Sign in to add a comment

Coverage error in generate_buildbot_json_coveragetest

Project Member Reported by martiniss@chromium.org, May 17 2018

Issue description

I get this presubmit error:


** Presubmit ERRORS **
generate_buildbot_json_coveragetest (0.30s) failed
Name                        Stmts   Miss  Cover   Missing
---------------------------------------------------------
generate_buildbot_json.py     402      8    98%   649-658, 672, 676

FATAL: Insufficient coverage (98%)


When uploading https://chromium-review.googlesource.com/c/chromium/src/+/1033326. My code shouldn't cause this, looks like a bug or something?
 

Comment 1 by kbr@chromium.org, May 17 2018

Blocking: 843511
Cc: dpranke@chromium.org thakis@chromium.org jbudorick@chromium.org
Labels: -Type-Bug Type-Bug-Regression
Status: Started (was: Assigned)
Caused by https://chromium-review.googlesource.com/1061597 . Fix in progress.

Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78fd87097942a66b7e09aba20255e7e5779f21c7

commit 78fd87097942a66b7e09aba20255e7e5779f21c7
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu May 17 01:15:52 2018

Fix generate_buildbot_json_coveragetest.

Actually cover the code which reads luci-milo.cfg.

Bug:  843842 
No-Try: True
Change-Id: Icd0fcaa2b6037c1ae3560a8ddb6e6ba777b3ac80
Tbr: thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1063270
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559380}
[modify] https://crrev.com/78fd87097942a66b7e09aba20255e7e5779f21c7/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/78fd87097942a66b7e09aba20255e7e5779f21c7/testing/buildbot/generate_buildbot_json_unittest.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a89036b61de53c4083da98659cfb63c53923784

commit 5a89036b61de53c4083da98659cfb63c53923784
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu May 17 22:33:41 2018

Make generate_buildbot_json_coveragetest mandatory.

coverage is now part of Chromium's vpython spec. This script is
crucial to Chrome's infrastructure, and changes should not be allowed
unless the standard of code coverage is maintained.

Bug:  843842 ,  662541 ,  792130 
Change-Id: I9164fe331045d13e08c1e1d40c79a01bac368ff9
Reviewed-on: https://chromium-review.googlesource.com/1063257
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559711}
[modify] https://crrev.com/5a89036b61de53c4083da98659cfb63c53923784/testing/buildbot/PRESUBMIT.py

Comment 4 by kbr@chromium.org, May 17 2018

Status: Fixed (was: Started)

Comment 5 by kbr@chromium.org, May 17 2018

Components: Tools>Test

Comment 6 by kbr@chromium.org, May 18 2018

Blocking: 844261

Sign in to add a comment