These are currently unused. We probably want to move the UKM recording to our safe browsing throttle though.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bf776b86d79c44b7d5ea62dea005bff5d58152a commit 1bf776b86d79c44b7d5ea62dea005bff5d58152a Author: Charlie Harrison <csharrison@chromium.org> Date: Fri May 18 13:39:11 2018 [subresource_filter] Move ukm recording out of page_load_metrics Bug: 843832 Change-Id: Ic9364d956486268a07189b4cb8e3c5ad0f62ea55 Reviewed-on: https://chromium-review.googlesource.com/1062825 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#559880} [modify] https://crrev.com/1bf776b86d79c44b7d5ea62dea005bff5d58152a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc [modify] https://crrev.com/1bf776b86d79c44b7d5ea62dea005bff5d58152a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h [modify] https://crrev.com/1bf776b86d79c44b7d5ea62dea005bff5d58152a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc [modify] https://crrev.com/1bf776b86d79c44b7d5ea62dea005bff5d58152a/components/subresource_filter/content/browser/BUILD.gn [modify] https://crrev.com/1bf776b86d79c44b7d5ea62dea005bff5d58152a/components/subresource_filter/content/browser/DEPS [modify] https://crrev.com/1bf776b86d79c44b7d5ea62dea005bff5d58152a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/1bf776b86d79c44b7d5ea62dea005bff5d58152a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c91a8d29f3dc55ffe345456663668a1d61f036e commit 9c91a8d29f3dc55ffe345456663668a1d61f036e Author: Charlie Harrison <csharrison@chromium.org> Date: Fri May 18 18:24:45 2018 Remove subresource_filter page_load_metrics This migrates one histogram which logs the ActivationDecision to the safe browsing throttle, since it makes sense to have UMA alongisde the UKM. PageLoad.Clients.SubresourceFilter.Count can be replaced by looking at the 0 bucket of: SubresourceFilter.PageLoad.NumSubresourceLoads.MatchedRules Bug: 843832 Change-Id: I8e1f0724abe841497e914cca5ef3ce2030827aad Reviewed-on: https://chromium-review.googlesource.com/1064175 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#559965} [modify] https://crrev.com/9c91a8d29f3dc55ffe345456663668a1d61f036e/chrome/browser/BUILD.gn [delete] https://crrev.com/71b6abec310f1025bd2147b6b0bc2bb7904a1c29/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc [delete] https://crrev.com/71b6abec310f1025bd2147b6b0bc2bb7904a1c29/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h [delete] https://crrev.com/71b6abec310f1025bd2147b6b0bc2bb7904a1c29/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc [modify] https://crrev.com/9c91a8d29f3dc55ffe345456663668a1d61f036e/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc [modify] https://crrev.com/9c91a8d29f3dc55ffe345456663668a1d61f036e/chrome/browser/subresource_filter/subresource_filter_browsertest.cc [modify] https://crrev.com/9c91a8d29f3dc55ffe345456663668a1d61f036e/chrome/test/BUILD.gn [modify] https://crrev.com/9c91a8d29f3dc55ffe345456663668a1d61f036e/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/9c91a8d29f3dc55ffe345456663668a1d61f036e/tools/metrics/histograms/histograms.xml
Comment 1 by csharrison@chromium.org
, May 17 2018Summary: Remove subresource_filter page_load_metrics metrics and reload whitelisting behavci (was: Remove subresource_filter page_load_metrics metrics)