New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843817 link

Starred by 2 users
Status: Verified
Owner:
chanli@chromium.org
Closed: May 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 846447



Sign in to add a comment

[Findit] Fit got 404s when fetching DEPS

Project Member Reported by chanli@chromium.org, May 16 2018 
This should be related to Findit tries to get DEPS from .DEPS.git first then from DEPS.

Switching the order should reduce the number of 404s.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/324161904ffb0f24d18d8155b8694790e7991deb

commit 324161904ffb0f24d18d8155b8694790e7991deb
Author: Chan <chanli@chromium.org>
Date: Wed May 16 23:57:02 2018

[Findit] Switch order of tries to fetch DEPS

Before Findit tries to fetch DEPS from 'repo_url/+/revision/.DEPS.git' first then 'repo_url/+/revision/DEPS', results in many 404 responses from gitiles. This change will switch the order of tries to reduce number of 404s.
Also modified unittests for this module.

Bug:  843817 
Change-Id: I65be0bc92b58d730d1757be97adaf8a60577a006
Reviewed-on: https://chromium-review.googlesource.com/1063010
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/324161904ffb0f24d18d8155b8694790e7991deb/appengine/findit/libs/deps/chrome_dependency_fetcher.py
[modify] https://crrev.com/324161904ffb0f24d18d8155b8694790e7991deb/appengine/findit/libs/deps/test/chrome_dependency_fetcher_test.py

Comment 2 by chanli@chromium.org, May 24 2018

Blocking: 846447
Status: Verified (was: Started)
►

Sign in to add a comment