New issue
Advanced search Search tips

Issue 843799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

wpt-importer blocked on failing lint

Project Member Reported by foolip@chromium.org, May 16 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36670a32fb24c76cbba10511911f17339204d2c9

commit 36670a32fb24c76cbba10511911f17339204d2c9
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Thu May 17 12:42:08 2018

Roll in new version of WPT tools

https://github.com/w3c/web-platform-tests/pull/10985 changed lint.py
and wpt-importer is now failing because of it:
https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17652

chromium.patch did not apply cleanly, so the changes had to be rebased
on the new wpt version.	This was much easier within the	wpt repo
itself, so the patch is	changed	to apply within	the repo.

Bug:  843799 , 843945
Change-Id: I1ed9895b2461243c38fea552706960a3b99db2b6
Reviewed-on: https://chromium-review.googlesource.com/1061458
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559502}
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.document-cookie.non-secure-expected.txt
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__host.http.non-secure-expected.txt
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.document-cookie.non-secure-expected.txt
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.http.non-secure-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/__secure.http.secure-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/prefix/document-cookie.non-secure-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/fetch-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-get-blank-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-get-blank-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-post-blank-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/form-post-blank-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/iframe-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/iframe-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/img-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/window-open-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/samesite/window-open-reload-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/secure/cookie-forcing-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/WebKit/LayoutTests/external/wpt/cookies/secure/create-cookie-http-expected.txt
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/README.chromium
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/WPTWhiteList
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/checkout.sh
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/chromium.patch
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/CONTRIBUTING.md
[delete] https://crrev.com/f4db209bd3b252a2b91901269ab47f64833d6a9d/third_party/blink/tools/blinkpy/third_party/wpt/wpt/config.default.json
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/lint/lint.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/item.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/sourcefile.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/browser.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/run.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/testfiles.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/config.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/server.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/__init__.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/base.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/openssl.py
[rename] https://crrev.com/36670a32fb24c76cbba10511911f17339204d2c9/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/pregenerated.py

Status: Fixed (was: Started)
The importer started to roll again: https://chromium-review.googlesource.com/c/chromium/src/+/1064011

This issue is fixed.

However, it looks like the import will fail because of some other issue (likely issue 839183). Let me take a look.

Sign in to add a comment