New issue
Advanced search Search tips

Issue 843798 link

Starred by 2 users
Status: Assigned
Owner:
harringtond@google.com
Cc:
carlosk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

prefetch items in stuck state

Project Member Reported by harringtond@chromium.org, May 16 2018 
GeneratePageBundleReconcileTask isn't running unless the user is in the NOW. That leads to old items in the SENT_GENERATE_PAGE_BUNDLE state. Unfortunately, stuck items just stay stuck, so a single user will report this continuously.

I'm going to transition stuck items to the FINISHED state. We also may want to consider running GeneratePageBundleReconcileTask outside of the NOW.

Comment 1 by carl...@google.com, May 17 2018

Cc: carlosk@chromium.org
Labels: -Restrict-View-Google OS-Android
This task is not referring to anything private so I'm removing the restrict view flag.

Comment 2 by dewittj@chromium.org, May 21 2018

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31fdd77a957b0662548f9eb93329916e5af50def

commit 31fdd77a957b0662548f9eb93329916e5af50def
Author: Dan Harrington <harringtond@chromium.org>
Date: Fri Jun 01 15:30:25 2018

retire stuck prefetch items

Prefetch items sometimes get stuck. We report when this happens, but
do not remove them. This CL removes those items.

Change-Id: Ifebce80771586690a135e6099f500127fb8321a1
Bug: 843798
Reviewed-on: https://chromium-review.googlesource.com/1062779
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563641}
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/prefetch_task_test_base.cc
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/prefetch_task_test_base.h
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/prefetch_types.cc
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/prefetch_types.h
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/stale_entry_finalizer_task.cc
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/stale_entry_finalizer_task_unittest.cc
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/store/prefetch_store_test_util.cc
[modify] https://crrev.com/31fdd77a957b0662548f9eb93329916e5af50def/components/offline_pages/core/prefetch/store/prefetch_store_test_util.h

Comment 4 by harringtond@google.com, Oct 15

Owner: harringtond@google.com
►

Sign in to add a comment