Static initializer checks broken? |
||
Issue descriptionhttps://cs.chromium.org/chromium/src/chromeos/services/assistant/assistant_manager_service_impl.cc?rcl=84fdb54ea8d7150d538d2e8c81a3ca896a2ad649&l=29 seems like it ought to generate a static initializer (and trip bots somewhere--I thought this used to block commit?). But it appears that didn't happen. Maybe clang is being super smart and noticing that the string in question fits in the internal buffer and so it can constexpr initialize it...?
,
May 17 2018
Also bug 843859.
,
May 17 2018
assistant_manager_service_impl.cc is also not built in my ChromeOS build. The enable_cros_libassistant GN variable has to be set to true, but I don't see any place in the public code that does that. So even if the bugs in comment 1 have been dealt with, there is still no way of detecting this particular issue.
,
May 17 2018
This particular change is fixed in a follow up CL. should have landed now. This file is only build for certain boards on ChromeOS. |
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, May 16 2018