New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843788 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move all old usage of MockFidoDevice test apis

Project Member Reported by hongjunchoi@chromium.org, May 16 2018

Issue description

Move all usage of old style test expectations calls to new 
test API's provided in MockFidoDevice
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af684eb199c6ee1de118c54d5ea95af5e4a215bd

commit af684eb199c6ee1de118c54d5ea95af5e4a215bd
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Fri Jun 08 21:05:18 2018

Use new test API's for U2fRegisterOperation tests

Replace all old expectation function calls for tests in
u2f_register_operation_unittests.cc file.

Note: As legacy old in u2f_sign_unittest.cc still uses the old API,
we keep the old API and remove it once U2F sign logic is migrated to
GetAssertionTask.

Bug:  843788 
Change-Id: I60ba3a47361a95f82fe173fdbab9d9bb4d29e3e4
Reviewed-on: https://chromium-review.googlesource.com/1069784
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565741}
[modify] https://crrev.com/af684eb199c6ee1de118c54d5ea95af5e4a215bd/device/fido/fido_test_data.h
[modify] https://crrev.com/af684eb199c6ee1de118c54d5ea95af5e4a215bd/device/fido/make_credential_handler_unittest.cc
[modify] https://crrev.com/af684eb199c6ee1de118c54d5ea95af5e4a215bd/device/fido/make_credential_task_unittest.cc
[modify] https://crrev.com/af684eb199c6ee1de118c54d5ea95af5e4a215bd/device/fido/mock_fido_device.h
[modify] https://crrev.com/af684eb199c6ee1de118c54d5ea95af5e4a215bd/device/fido/u2f_register_operation_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment