WebUI: MD-refresh button styles not applied to some web views. |
|||||||||||||
Issue descriptionFound some buttons that did not receive the MD-refresh styles. chrome://sync-confirmation ([1], this appears when you first sign into chrome) chrome://sync-confirmation/?consent-bump ([2], when identity-consistency and unified-consent flags are on) chrome://signin-email-confirmation ([3], this appears when you sign into chrome with account A, sign out, then sign in with account B) [1]https://cs.chromium.org/chromium/src/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html [2]https://cs.chromium.org/chromium/src/chrome/browser/resources/signin/dice_sync_confirmation/sync_confirmation_app.html [3]https://cs.chromium.org/chromium/src/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html See screenshots.
,
May 16 2018
FYI signin-email-confirmation already tracked by issue 843348 . Maybe we should merge to this issue here?
,
May 19 2018
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d20cee05dad7b11365c0c39b6ffa5b5620a028a8 commit d20cee05dad7b11365c0c39b6ffa5b5620a028a8 Author: dpapad <dpapad@chromium.org> Date: Mon May 21 21:52:18 2018 WebUI internet-config-dialog: Apply shared MD Refresh button style. Bug: 843770 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5026217516d2c2b82c876d56086865c5ee9aa668 Reviewed-on: https://chromium-review.googlesource.com/1066946 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#560354} [modify] https://crrev.com/d20cee05dad7b11365c0c39b6ffa5b5620a028a8/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
,
May 21 2018
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bba7e8ac988500dc87a1de6c4809628a9415a1c8 commit bba7e8ac988500dc87a1de6c4809628a9415a1c8 Author: dpapad <dpapad@chromium.org> Date: Tue May 22 22:34:42 2018 WebUI MD Refresh: Apply new button style in various signin dialogs. Bug: 843770 , 843348 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifb8517c90cecd569b6600b896329d713a96c82e7 Reviewed-on: https://chromium-review.googlesource.com/1068074 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#560818} [modify] https://crrev.com/bba7e8ac988500dc87a1de6c4809628a9415a1c8/chrome/browser/resources/signin/dice_sync_confirmation/sync_confirmation_app.html [modify] https://crrev.com/bba7e8ac988500dc87a1de6c4809628a9415a1c8/chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html [modify] https://crrev.com/bba7e8ac988500dc87a1de6c4809628a9415a1c8/chrome/browser/resources/signin/signin_error/signin_error.html [modify] https://crrev.com/bba7e8ac988500dc87a1de6c4809628a9415a1c8/chrome/browser/resources/signin/signin_shared_css.html [modify] https://crrev.com/bba7e8ac988500dc87a1de6c4809628a9415a1c8/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html [modify] https://crrev.com/bba7e8ac988500dc87a1de6c4809628a9415a1c8/ui/webui/resources/cr_elements/paper_button_style_css.html
,
May 22 2018
All the UI surfaces mentioned in this bug should be updated now.
,
May 22 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by scottchen@chromium.org
, May 16 2018