mash_browser_tests crash when running SavePageOriginalVsSavedComparisonTest.CrossSiteObject |
|||||
Issue descriptionREPRO STEPS: 1. Patch-in https://crrev.com/c/1060470 2. Build browser_tests for CrOS dcheck_always_on = true is_component_build = true is_debug = false target_os = "chromeos" use_goma = true use_vaapi = true 3. Run SavePageOriginalVsSavedComparisonTest.CrossSiteObject test opting into mash: $ out/cros/browser_tests --gtest_filter=*SavePageOriginalVsSavedComparisonTest.CrossSiteObject* --enable-features=Mash --override-use-software-gl-for-tests EXPECTED: the test passes ACTUAL: crash here: #1 0x000004b7b195 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fdb6cb36cb0 <unknown> #3 0x0000064a571c base::flat_map<>::operator[]() #4 0x0000064a5602 viz::HostFrameSinkManager::RegisterFrameSinkId() #5 0x000002f00483 content::EmbeddedFrameSinkImpl::EmbeddedFrameSinkImpl() #6 0x000002f00e17 content::EmbeddedFrameSinkProviderImpl::RegisterEmbeddedFrameSink() #7 0x00000317c334 blink::mojom::EmbeddedFrameSinkProviderStubDispatch::Accept() NOTE: The test loads the following test document. - I verified that there is no crash after taking out the <object> tag below - I verified that there is still a crash even if the video is same-site (i.e. there are no OOPIFs) <!doctype html> <html> <head></head> <body> ... <object data="/cross-site/bar.com/save_page/a.htm">err_no_object_data</object> <object data="/cross-site/bar.com/save_page/svg.svg">err_no_object_data</object> <object data="/cross-site/bar.com/media/bigbuck.webm">err_no_object_data</object> ... </body> </html>
,
May 17 2018
lukasza: What does the test do with the document? Why is there a video object in it? The crash appears to be in the code to start initializing IPC channels for the video CompositorFrameSink, so the test has started teardown before the video has started to show up.
,
May 17 2018
Ohhhh, this is mash. No one has made offscreen canvas or the new video path work with mash yet. It's not that HostFrameSinkManager has already been destroyed, it's that it never existed because it's in a different process with mash.
,
May 22 2018
,
May 25 2018
,
May 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f78f6e9d658e473e95a27c00bd149cf411f134b commit 7f78f6e9d658e473e95a27c00bd149cf411f134b Author: Mounir Lamouri <mlamouri@chromium.org> Date: Sat May 26 18:49:57 2018 VideoSurfaceLayer: disable feature when Mash in enabled. Mash needs to implement some changes server side for this feature to work. Instead of crashing when a video is playing, this simply forces the feature off is Mash in on. Bug: 843760 , 831357 Change-Id: Ia0b95fecb50ba316f8037bf835aa5fab2e8f201f Reviewed-on: https://chromium-review.googlesource.com/1073671 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#562127} [modify] https://crrev.com/7f78f6e9d658e473e95a27c00bd149cf411f134b/content/renderer/media/media_factory.cc [modify] https://crrev.com/7f78f6e9d658e473e95a27c00bd149cf411f134b/testing/buildbot/filters/mash.browser_tests.filter
,
May 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jamescook@chromium.org
, May 17 2018