New issue
Advanced search Search tips

Issue 843750 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: May 2018
Cc:
dcasta...@chromium.org
jamescook@chromium.org
ovanieva@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
nightlight



Sign in to add a comment

Night Light matrix can end up being applied in two places

Project Member Reported by afakhry@chromium.org, May 16 2018 
We noticed that sometimes on resume while NL is on, the screen looks very red, the temperature seems to be double its value. 

Apparently sometimes we get into this transient state where we think the display doesn't support CRTC matrix, so we apply the compositor matrix. Then that state is corrected, so we apply the CRTC matrix without resetting the compositor matrix to identity. Hence NL shows double the effect.


Uploading a fix for this shortly.
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a10a3a3e7f9215c729b1cf5aee259cac12c5db

commit e8a10a3a3e7f9215c729b1cf5aee259cac12c5db
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu May 17 17:16:08 2018

Assert Matrix is applied only in one place.

If CRTC matrix support detection is switched from
off to on while Night Light is enabled, we should
apply the matrix on the CRTC and reset the one on
the compositor to identity.

BUG= 843750 
TEST=Added new test.

Change-Id: I087be08e53f6d53b7d5c4f0679b83a7f56b26c0e
Reviewed-on: https://chromium-review.googlesource.com/1062727
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559582}
[modify] https://crrev.com/e8a10a3a3e7f9215c729b1cf5aee259cac12c5db/ash/display/display_color_manager.cc
[modify] https://crrev.com/e8a10a3a3e7f9215c729b1cf5aee259cac12c5db/ash/system/night_light/night_light_controller.cc
[modify] https://crrev.com/e8a10a3a3e7f9215c729b1cf5aee259cac12c5db/ash/system/night_light/night_light_controller.h
[modify] https://crrev.com/e8a10a3a3e7f9215c729b1cf5aee259cac12c5db/ash/system/night_light/night_light_controller_unittest.cc

Comment 2 by afakhry@chromium.org, May 17 2018

Status: Fixed (was: Started)
►

Sign in to add a comment