headless_browsertests racy under tsan |
||||||
Issue descriptionI'm adding more tests to bots: https://chromium-review.googlesource.com/c/chromium/src/+/1061795/ https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_tsan_rel_ng/17466 headless_browsertests have many race reports under tsan, so I won't add them to the tsan bot at this point.
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3b15b26491f649cffaccae05a4370f8367ddbcf commit e3b15b26491f649cffaccae05a4370f8367ddbcf Author: Pavel Feldman <pfeldman@chromium.org> Date: Sat May 19 20:57:11 2018 Revert "Reduce number of different test suite configurations." This reverts commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a. Reason for revert: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/11941 Original change's description: > Reduce number of different test suite configurations. > > - Remove all the "non_clang" and "_fyi" configs -- the clang > waterfall and the FYI waterfall should default to running the > same tests as the real waterfalls unless explicitly opted out. > Deviations here were very likely not intentional. > - This requires running chrome_cleaner_unittests on the regular > win bots, which seems like a good change anyhow. > - Just include angle_unittests in chromium_gtests instead of > spuriously adding it here and there (but on all platforms). > We've had issues with this test unintentionally running on too > few bots. > - Rename aura_gtests to non_android_and_mac_gtests > - Include gl_tests in the normal chromium_linux_gtests and > chromium_android_gtests suites instead of having separate > _and_gl configs > - Add gcm_unit_tests to chromium_gtests since it effectively > ran everywhere already, this allows deleting > non_android_and_cast_chromium_gtests. Use similar tactics to > remove non_android_and_cast_and_chromeos_chromium_gtests. > - Address most "TODO: merge back to X" TODOs > > The main effect is that this adds many tests to the chromium.clang > waterfall, making it more consistent with the main waterfall. > It also adds a couple of binaries to other waterfalls. > > Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 > TBR=disabled test owners > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830 > Reviewed-on: https://chromium-review.googlesource.com/1061795 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560147} TBR=thakis@chromium.org,dpranke@chromium.org,kbr@chromium.org Change-Id: I645e08d0ae374f181836e5d3749f39e17e54d9f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 , 831999, 844582 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1067052 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560158} [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/media/cast/receiver/audio_decoder_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.clang.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.linux.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.mac.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.memory.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.win.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suites.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/README.chromium [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/task_runner/task_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/tools/battor_agent/battor_connection_impl_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/ui/compositor/layer_unittest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af48666492299fa11d0b6d4f6dc3f6065be7b277 commit af48666492299fa11d0b6d4f6dc3f6065be7b277 Author: Nico Weber <thakis@chromium.org> Date: Wed Jun 06 17:01:19 2018 Run headless_browsertests, headless_unittests on more bots. Run headless_browsertests, headless_unittests on the the clang tot bots, and on some memory bots. Both suites are very leaky, so they don't run on asan bots, and headless_browsertests is also very racy so it doesn't run under tsan, but headless_unittests runs under tsan. Both run under msan and cfi. They also run under asan/mac, which seems to be happy. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511, 843732 , 843734 Change-Id: I3ba57446830d44f3651100e216f1d546ee7532b6 Reviewed-on: https://chromium-review.googlesource.com/1088754 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564931} [modify] https://crrev.com/af48666492299fa11d0b6d4f6dc3f6065be7b277/testing/buildbot/chromium.clang.json [modify] https://crrev.com/af48666492299fa11d0b6d4f6dc3f6065be7b277/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/af48666492299fa11d0b6d4f6dc3f6065be7b277/testing/buildbot/chromium.memory.json [modify] https://crrev.com/af48666492299fa11d0b6d4f6dc3f6065be7b277/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/af48666492299fa11d0b6d4f6dc3f6065be7b277/testing/buildbot/test_suites.pyl
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a2f9c0c206424442bf3de66f53b448152deeeb4 commit 1a2f9c0c206424442bf3de66f53b448152deeeb4 Author: Hector Carmona <hcarmona@chromium.org> Date: Wed Jun 06 17:38:01 2018 Revert "Run headless_browsertests, headless_unittests on more bots." This reverts commit af48666492299fa11d0b6d4f6dc3f6065be7b277. Reason for revert: Suspected cause of compile error: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/12405 See: https://crbug.com/844865 Original change's description: > Run headless_browsertests, headless_unittests on more bots. > > Run headless_browsertests, headless_unittests on the the clang tot bots, > and on some memory bots. Both suites are very leaky, so they don't run on > asan bots, and headless_browsertests is also very racy so it doesn't run under > tsan, but headless_unittests runs under tsan. Both run under msan and cfi. > They also run under asan/mac, which seems to be happy. > > This is part of an effort to reduce the number of test configurations. > Originally reviewed as part of https://chromium-review.googlesource.com/1061795, > which I'm now landing in smaller pieces. > > TBR=kbr > > Bug: 843511, 843732 , 843734 > Change-Id: I3ba57446830d44f3651100e216f1d546ee7532b6 > Reviewed-on: https://chromium-review.googlesource.com/1088754 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564931} TBR=thakis@chromium.org,kbr@chromium.org Change-Id: Ie784cbd8138b0096d538c3e2212d45bdfd18255d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843511, 843732 , 843734 Reviewed-on: https://chromium-review.googlesource.com/1089211 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#564947} [modify] https://crrev.com/1a2f9c0c206424442bf3de66f53b448152deeeb4/testing/buildbot/chromium.clang.json [modify] https://crrev.com/1a2f9c0c206424442bf3de66f53b448152deeeb4/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1a2f9c0c206424442bf3de66f53b448152deeeb4/testing/buildbot/chromium.memory.json [modify] https://crrev.com/1a2f9c0c206424442bf3de66f53b448152deeeb4/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/1a2f9c0c206424442bf3de66f53b448152deeeb4/testing/buildbot/test_suites.pyl
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c149502277c1441eec693c3ec160462e150000b commit 1c149502277c1441eec693c3ec160462e150000b Author: Nico Weber <thakis@chromium.org> Date: Sat Jun 09 04:10:45 2018 Run headless tests on memory waterfall. Relands the last missing bit of https://chromium-review.googlesource.com/1088754 This got reverted the last time because the msan bot had a too-old version of Java. This should now be fixed. TBR=kbr Bug: 843511, 850731 , 844865 , 843732 , 843734 Change-Id: I2359e6e721fa603117dd2a0a2f11f459ee2a2ddf Reviewed-on: https://chromium-review.googlesource.com/1094036 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565841} [modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/chromium.memory.json [modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/1c149502277c1441eec693c3ec160462e150000b/testing/buildbot/test_suites.pyl
,
Jun 15 2018
,
Jun 15 2018
,
Dec 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e42384992ccc9874365ba5f28ae389d527d1401 commit 7e42384992ccc9874365ba5f28ae389d527d1401 Author: Andrey Kosyakov <caseq@chromium.org> Date: Sat Dec 15 02:50:23 2018 Fix a race in headless virtual time & compositor tests A lack of explicit start time for frame caused real time clock to be used for frame start, which may cause next frame to be dropped if its (virtual) timestamp is earlier. Bug: 909043 , 843734 Change-Id: I4a909be2e1e4f69f0834a87ffdb3d402c450adfc Reviewed-on: https://chromium-review.googlesource.com/c/1379181 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#616925} [modify] https://crrev.com/7e42384992ccc9874365ba5f28ae389d527d1401/headless/test/data/protocol/emulation/compositor-image-animation-test.js [modify] https://crrev.com/7e42384992ccc9874365ba5f28ae389d527d1401/headless/test/data/protocol/helpers/virtual-time-controller.js
,
Dec 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c38112ee879acdb2ddea94d2c18074b9ecafa6 commit d1c38112ee879acdb2ddea94d2c18074b9ecafa6 Author: Andrey Kosyakov <caseq@chromium.org> Date: Sun Dec 16 23:11:31 2018 Suppress data race in ScopedTimeClockOverrides Bug: 910524, 843734 Change-Id: I23301797735349729135ea792f6ed4805bb5100c Reviewed-on: https://chromium-review.googlesource.com/c/1378974 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#617019} [modify] https://crrev.com/d1c38112ee879acdb2ddea94d2c18074b9ecafa6/build/sanitizers/tsan_suppressions.cc
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9b8c4271ef3341ac4d618d874de570603dc3cdd commit b9b8c4271ef3341ac4d618d874de570603dc3cdd Author: Andrey Kosyakov <caseq@chromium.org> Date: Mon Dec 17 20:49:18 2018 Fix a crash in InspectorEmulationAgent::VirtualTimeBudgetExpired() The crash was due to the emulation agent receiving VirtualTimeBudgetExpired() in the process of page tear down after navigation while running HeadlessProtocolBrowserTest.VirtualTimeCrossProcessNavigation test. Bug: 843734 Change-Id: I9846bd8716c16af9aec15778b90ed2a69555a939 Reviewed-on: https://chromium-review.googlesource.com/c/1380652 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#617216} [modify] https://crrev.com/b9b8c4271ef3341ac4d618d874de570603dc3cdd/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b0ebec062f0910e3edc1cf3bb590870e7cc4d06 commit 9b0ebec062f0910e3edc1cf3bb590870e7cc4d06 Author: Andrey Kosyakov <caseq@chromium.org> Date: Mon Dec 17 22:35:01 2018 Use base::AtomicFlag for CrashHandlerHostLinux::shutting_down_ ... to keep TSAN happy while running CrashReporterTest.GenerateMinidump in headless_browsertests. BUG= 843734 Change-Id: Idfb95344e8bdb275792b62b3edeade3ce891d33c Reviewed-on: https://chromium-review.googlesource.com/c/1380970 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#617262} [modify] https://crrev.com/9b0ebec062f0910e3edc1cf3bb590870e7cc4d06/components/crash/content/browser/crash_handler_host_linux.cc [modify] https://crrev.com/9b0ebec062f0910e3edc1cf3bb590870e7cc4d06/components/crash/content/browser/crash_handler_host_linux.h
,
Dec 18
All tests pass locally for me now.
,
Dec 18
Awesome, thanks! Can you remove https://cs.chromium.org/chromium/src/testing/buildbot/test_suite_exceptions.pyl?q=%22843734%22&sq=package:chromium&g=0&l=640 and https://cs.chromium.org/chromium/src/testing/buildbot/test_suite_exceptions.pyl?q=%22843734%22&sq=package:chromium&g=0&l=650 and then re-run testing/buildbot/generate_buildbot_json.py and upload that and send it to me for review, so that the bots run these tests (or just the first one if only that one works) and make sure this doesn't regress?
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55fd4c2a32c89a7f8e7b20595d5288a6a2bd8386 commit 55fd4c2a32c89a7f8e7b20595d5288a6a2bd8386 Author: Andrey Kosyakov <caseq@chromium.org> Date: Tue Dec 18 12:25:16 2018 Remove exceptions for headless_browsertests and headless_unittests on ASAN and TSAN bots Bug: 843734 , 843732 Change-Id: Ie280e71ace96ee2d448175370d660ef910537cba Reviewed-on: https://chromium-review.googlesource.com/c/1381715 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#617453} [modify] https://crrev.com/55fd4c2a32c89a7f8e7b20595d5288a6a2bd8386/testing/buildbot/chromium.clang.json [modify] https://crrev.com/55fd4c2a32c89a7f8e7b20595d5288a6a2bd8386/testing/buildbot/chromium.memory.json [modify] https://crrev.com/55fd4c2a32c89a7f8e7b20595d5288a6a2bd8386/testing/buildbot/test_suite_exceptions.pyl
,
Dec 18
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/31261 Thanks much! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, May 19 2018