unstarted_task_test.DoNotDeleteTask2 leaks |
|||
Issue descriptionI'm enabilng more tests in https://chromium-review.googlesource.com/c/chromium/src/+/1061795/ unstarted_task_test.DoNotDeleteTask2 leaks on asan: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_asan_rel_ng/13140 [ RUN ] unstarted_task_test.DoNotDeleteTask2 [ OK ] unstarted_task_test.DoNotDeleteTask2 (0 ms) [----------] 1 test from unstarted_task_test (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (0 ms total) [ PASSED ] 1 test. ================================================================= ==15861==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 320 byte(s) in 1 object(s) allocated from: #0 0x5bbd62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 #1 0x5c7d39 in rtc::unstarted_task_test_DoNotDeleteTask2_Test::TestBody() third_party/libjingle_xmpp/task_runner/task_unittest.cc:539:3 #2 0x96d7e2 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc #3 0x96ef54 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11 #4 0x970356 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28 #5 0x996066 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43 #6 0x9952b2 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc #7 0x9b0347 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #8 0x9b0347 in base::TestSuite::Run() base/test/test_suite.cc:275 #9 0x9b9a6b in Run base/callback.h:96:12 #10 0x9b9a6b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #11 0x9b94fc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10 #12 0x9affc8 in main base/test/run_all_unittests.cc:12:10 #13 0x7fd77131bf44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 Indirect leak of 48 byte(s) in 1 object(s) allocated from: #0 0x5bbd62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 #1 0x5c8029 in __libcpp_allocate buildtools/third_party/libc++/trunk/include/new:259:10 #2 0x5c8029 in allocate buildtools/third_party/libc++/trunk/include/memory:1799 #3 0x5c8029 in allocate buildtools/third_party/libc++/trunk/include/memory:1548 #4 0x5c8029 in __allocate_node buildtools/third_party/libc++/trunk/include/list:1079 #5 0x5c8029 in push_back buildtools/third_party/libc++/trunk/include/list:1595 #6 0x5c8029 in connect<rtc::IdTimeoutTask> third_party/webrtc/rtc_base/sigslot.h:554 #7 0x5c8029 in IdTimeoutTask third_party/libjingle_xmpp/task_runner/task_unittest.cc:50 #8 0x5c8029 in HappyTask third_party/libjingle_xmpp/task_runner/task_unittest.cc:81 #9 0x5c8029 in rtc::unstarted_task_test_DoNotDeleteTask2_Test::TestBody() third_party/libjingle_xmpp/task_runner/task_unittest.cc:539 #10 0x96d7e2 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc #11 0x96ef54 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11 #12 0x970356 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28 #13 0x996066 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43 #14 0x9952b2 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc #15 0x9b0347 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #16 0x9b0347 in base::TestSuite::Run() base/test/test_suite.cc:275 #17 0x9b9a6b in Run base/callback.h:96:12 #18 0x9b9a6b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #19 0x9b94fc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10 #20 0x9affc8 in main base/test/run_all_unittests.cc:12:10 #21 0x7fd77131bf44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x5bbd62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 #1 0x5c87e8 in __libcpp_allocate buildtools/third_party/libc++/trunk/include/new:259:10 #2 0x5c87e8 in allocate buildtools/third_party/libc++/trunk/include/memory:1799 #3 0x5c87e8 in allocate buildtools/third_party/libc++/trunk/include/memory:1548 #4 0x5c87e8 in __construct_node<sigslot::_signal_base_interface *const &> buildtools/third_party/libc++/trunk/include/__tree:2191 #5 0x5c87e8 in __emplace_unique_key_args<sigslot::_signal_base_interface *, sigslot::_signal_base_interface *const &> buildtools/third_party/libc++/trunk/include/__tree:2137 #6 0x5c87e8 in __insert_unique buildtools/third_party/libc++/trunk/include/__tree:1273 #7 0x5c87e8 in insert buildtools/third_party/libc++/trunk/include/set:599 #8 0x5c87e8 in sigslot::has_slots<sigslot::single_threaded>::do_signal_connect(sigslot::has_slots_interface*, sigslot::_signal_base_interface*) third_party/webrtc/rtc_base/sigslot.h:509 #9 0x5c8142 in signal_connect third_party/webrtc/rtc_base/sigslot.h:248:5 #10 0x5c8142 in connect<rtc::IdTimeoutTask> third_party/webrtc/rtc_base/sigslot.h:555 #11 0x5c8142 in IdTimeoutTask third_party/libjingle_xmpp/task_runner/task_unittest.cc:50 #12 0x5c8142 in HappyTask third_party/libjingle_xmpp/task_runner/task_unittest.cc:81 #13 0x5c8142 in rtc::unstarted_task_test_DoNotDeleteTask2_Test::TestBody() third_party/libjingle_xmpp/task_runner/task_unittest.cc:539 #14 0x96d7e2 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc #15 0x96ef54 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11 #16 0x970356 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28 #17 0x996066 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43 #18 0x9952b2 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc #19 0x9b0347 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #20 0x9b0347 in base::TestSuite::Run() base/test/test_suite.cc:275 #21 0x9b9a6b in Run base/callback.h:96:12 #22 0x9b9a6b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #23 0x9b94fc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10 #24 0x9affc8 in main base/test/run_all_unittests.cc:12:10 #25 0x7fd77131bf44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x5bbd62 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 #1 0x9abfca in Initialize third_party/libjingle_xmpp/task_runner/taskparent.cc:41:19 #2 0x9abfca in rtc::TaskParent::TaskParent(rtc::Task*, rtc::TaskParent*) third_party/libjingle_xmpp/task_runner/taskparent.cc:27 #3 0x9a945c in rtc::Task::Task(rtc::TaskParent*) third_party/libjingle_xmpp/task_runner/task.cc:20:7 #4 0x5c7d47 in IdTimeoutTask third_party/libjingle_xmpp/task_runner/task_unittest.cc:49:48 #5 0x5c7d47 in HappyTask third_party/libjingle_xmpp/task_runner/task_unittest.cc:81 #6 0x5c7d47 in rtc::unstarted_task_test_DoNotDeleteTask2_Test::TestBody() third_party/libjingle_xmpp/task_runner/task_unittest.cc:539 #7 0x96d7e2 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc #8 0x96ef54 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11 #9 0x970356 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28 #10 0x996066 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43 #11 0x9952b2 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc #12 0x9b0347 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #13 0x9b0347 in base::TestSuite::Run() base/test/test_suite.cc:275 #14 0x9b9a6b in Run base/callback.h:96:12 #15 0x9b9a6b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225 #16 0x9b94fc in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10 #17 0x9affc8 in main base/test/run_all_unittests.cc:12:10 #18 0x7fd77131bf44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 ----------------------------------------------------- Suppressions used: count bytes template 23 1904 third_party/fontconfig/ ----------------------------------------------------- SUMMARY: AddressSanitizer: 432 byte(s) leaked in 4 allocation(s).
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3b15b26491f649cffaccae05a4370f8367ddbcf commit e3b15b26491f649cffaccae05a4370f8367ddbcf Author: Pavel Feldman <pfeldman@chromium.org> Date: Sat May 19 20:57:11 2018 Revert "Reduce number of different test suite configurations." This reverts commit 589b7b025231a8a69a69c1a7f2a9091f5b9fdc9a. Reason for revert: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/11941 Original change's description: > Reduce number of different test suite configurations. > > - Remove all the "non_clang" and "_fyi" configs -- the clang > waterfall and the FYI waterfall should default to running the > same tests as the real waterfalls unless explicitly opted out. > Deviations here were very likely not intentional. > - This requires running chrome_cleaner_unittests on the regular > win bots, which seems like a good change anyhow. > - Just include angle_unittests in chromium_gtests instead of > spuriously adding it here and there (but on all platforms). > We've had issues with this test unintentionally running on too > few bots. > - Rename aura_gtests to non_android_and_mac_gtests > - Include gl_tests in the normal chromium_linux_gtests and > chromium_android_gtests suites instead of having separate > _and_gl configs > - Add gcm_unit_tests to chromium_gtests since it effectively > ran everywhere already, this allows deleting > non_android_and_cast_chromium_gtests. Use similar tactics to > remove non_android_and_cast_and_chromeos_chromium_gtests. > - Address most "TODO: merge back to X" TODOs > > The main effect is that this adds many tests to the chromium.clang > waterfall, making it more consistent with the main waterfall. > It also adds a couple of binaries to other waterfalls. > > Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 ,831999, 844582 > TBR=disabled test owners > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I67c3980009fc07897f1f6bab424ef6c5f11d4830 > Reviewed-on: https://chromium-review.googlesource.com/1061795 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560147} TBR=thakis@chromium.org,dpranke@chromium.org,kbr@chromium.org Change-Id: I645e08d0ae374f181836e5d3749f39e17e54d9f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843511, 843726 , 843729 , 843731 , 843732 , 843734 , 831999, 844582 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1067052 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560158} [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/media/cast/receiver/audio_decoder_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.android.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.clang.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.linux.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.mac.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.memory.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/chromium.win.json [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/test_suites.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/README.chromium [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/third_party/libjingle_xmpp/task_runner/task_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/tools/battor_agent/battor_connection_impl_unittest.cc [modify] https://crrev.com/e3b15b26491f649cffaccae05a4370f8367ddbcf/ui/compositor/layer_unittest.cc
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d94a8e92883f9587859a27f54cfe3a37072db3bf commit d94a8e92883f9587859a27f54cfe3a37072db3bf Author: Nico Weber <thakis@chromium.org> Date: Mon May 21 15:10:33 2018 run boringssl_crypto_tests, boringssl_ssl_tests, libjingle_xmpp_unittests, storage_unittests everywhere Adds these suites to some memory bots, the clang tot bots, and fyi bots. Also disable one libjingle_xmpp_unittests under asan since it fails there. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511, 843731 Change-Id: I03f1117bba3dffe970caaca468cf28723f45c005 Reviewed-on: https://chromium-review.googlesource.com/1067360 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560269} [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/testing/buildbot/chromium.clang.json [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/testing/buildbot/chromium.memory.json [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/testing/buildbot/test_suites.pyl [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/third_party/libjingle_xmpp/README.chromium [modify] https://crrev.com/d94a8e92883f9587859a27f54cfe3a37072db3bf/third_party/libjingle_xmpp/task_runner/task_unittest.cc
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/894859c7246aa50eb3120ba3d998da9c699ddf2b commit 894859c7246aa50eb3120ba3d998da9c699ddf2b Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Jan 16 01:48:13 2019 Delete leaky test unstarted_task_test.DoNotDeleteTask2 The test was leaking memory and we don't really need it. Bug: 843731 Change-Id: I0cbd634103cca44500acd7fbb7035e0377a2f200 Reviewed-on: https://chromium-review.googlesource.com/c/1413380 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#623000} [modify] https://crrev.com/894859c7246aa50eb3120ba3d998da9c699ddf2b/third_party/libjingle_xmpp/task_runner/task_unittest.cc
,
Jan 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 19 2018